Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Side by Side Diff: chrome/browser/android/webapps/add_to_homescreen_dialog_helper.h

Issue 2278693002: Reorder functions in add_to_homescreen_dialog_helper.cc to match order in .h file (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge branch 'master' into webapk_dialog_detector00 Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/android/webapps/add_to_homescreen_dialog_helper.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_ANDROID_WEBAPPS_ADD_TO_HOMESCREEN_DIALOG_HELPER_H_ 5 #ifndef CHROME_BROWSER_ANDROID_WEBAPPS_ADD_TO_HOMESCREEN_DIALOG_HELPER_H_
6 #define CHROME_BROWSER_ANDROID_WEBAPPS_ADD_TO_HOMESCREEN_DIALOG_HELPER_H_ 6 #define CHROME_BROWSER_ANDROID_WEBAPPS_ADD_TO_HOMESCREEN_DIALOG_HELPER_H_
7 7
8 #include "base/android/jni_android.h" 8 #include "base/android/jni_android.h"
9 #include "base/android/scoped_java_ref.h" 9 #include "base/android/scoped_java_ref.h"
10 #include "base/macros.h" 10 #include "base/macros.h"
(...skipping 11 matching lines...) Expand all
22 class GURL; 22 class GURL;
23 struct ShortcutInfo; 23 struct ShortcutInfo;
24 24
25 // AddToHomescreenDialogHelper is the C++ counterpart of 25 // AddToHomescreenDialogHelper is the C++ counterpart of
26 // org.chromium.chrome.browser's AddToHomescreenDialogHelper in Java. The object 26 // org.chromium.chrome.browser's AddToHomescreenDialogHelper in Java. The object
27 // is owned by the Java object. It is created from there via a JNI (Initialize) 27 // is owned by the Java object. It is created from there via a JNI (Initialize)
28 // call and MUST BE DESTROYED via Destroy(). 28 // call and MUST BE DESTROYED via Destroy().
29 class AddToHomescreenDialogHelper : 29 class AddToHomescreenDialogHelper :
30 public AddToHomescreenDataFetcher::Observer { 30 public AddToHomescreenDataFetcher::Observer {
31 public: 31 public:
32 // Registers JNI hooks.
33 static bool RegisterAddToHomescreenDialogHelper(JNIEnv* env);
34
32 AddToHomescreenDialogHelper(JNIEnv* env, 35 AddToHomescreenDialogHelper(JNIEnv* env,
33 jobject obj, 36 jobject obj,
34 content::WebContents* web_contents); 37 content::WebContents* web_contents);
35 38
36 // Called by the Java counterpart to destroy its native half. 39 // Called by the Java counterpart to destroy its native half.
37 void Destroy(JNIEnv* env, const base::android::JavaParamRef<jobject>& obj); 40 void Destroy(JNIEnv* env, const base::android::JavaParamRef<jobject>& obj);
38 41
39 // Registers JNI hooks.
40 static bool RegisterAddToHomescreenDialogHelper(JNIEnv* env);
41
42 // Adds a shortcut to the current URL to the Android home screen. 42 // Adds a shortcut to the current URL to the Android home screen.
43 void AddShortcut(JNIEnv* env, 43 void AddShortcut(JNIEnv* env,
44 const base::android::JavaParamRef<jobject>& obj, 44 const base::android::JavaParamRef<jobject>& obj,
45 const base::android::JavaParamRef<jstring>& title); 45 const base::android::JavaParamRef<jstring>& title);
46 46
47 // AddToHomescreenDataFetcher::Observer
48 void OnUserTitleAvailable(const base::string16& user_title) override;
49 void OnDataAvailable(const ShortcutInfo& info, const SkBitmap& icon) override;
50 SkBitmap FinalizeLauncherIconInBackground(const SkBitmap& icon,
51 const GURL& url,
52 bool* is_generated) override;
53
54 private: 47 private:
55 virtual ~AddToHomescreenDialogHelper(); 48 virtual ~AddToHomescreenDialogHelper();
56 49
57 // Called only when the AddToHomescreenDataFetcher has retrieved all of the 50 // Called only when the AddToHomescreenDataFetcher has retrieved all of the
58 // data needed to add the shortcut. 51 // data needed to add the shortcut.
59 void AddShortcut(const ShortcutInfo& info, const SkBitmap& icon); 52 void AddShortcut(const ShortcutInfo& info, const SkBitmap& icon);
60 53
61 void RecordAddToHomescreen(); 54 void RecordAddToHomescreen();
62 55
56 // AddToHomescreenDataFetcher::Observer:
57 void OnUserTitleAvailable(const base::string16& user_title) override;
58 void OnDataAvailable(const ShortcutInfo& info, const SkBitmap& icon) override;
59 SkBitmap FinalizeLauncherIconInBackground(const SkBitmap& icon,
60 const GURL& url,
61 bool* is_generated) override;
62
63 // Points to the Java object. 63 // Points to the Java object.
64 base::android::ScopedJavaGlobalRef<jobject> java_ref_; 64 base::android::ScopedJavaGlobalRef<jobject> java_ref_;
65 65
66 // Whether the user has requested that a shortcut be added while a fetch was 66 // Whether the user has requested that a shortcut be added while a fetch was
67 // in progress. 67 // in progress.
68 bool add_shortcut_pending_; 68 bool add_shortcut_pending_;
69 69
70 // Fetches data required to add a shortcut. 70 // Fetches data required to add a shortcut.
71 scoped_refptr<AddToHomescreenDataFetcher> data_fetcher_; 71 scoped_refptr<AddToHomescreenDataFetcher> data_fetcher_;
72 72
73 DISALLOW_COPY_AND_ASSIGN(AddToHomescreenDialogHelper); 73 DISALLOW_COPY_AND_ASSIGN(AddToHomescreenDialogHelper);
74 }; 74 };
75 75
76 #endif // CHROME_BROWSER_ANDROID_WEBAPPS_ADD_TO_HOMESCREEN_DIALOG_HELPER_H_ 76 #endif // CHROME_BROWSER_ANDROID_WEBAPPS_ADD_TO_HOMESCREEN_DIALOG_HELPER_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/android/webapps/add_to_homescreen_dialog_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698