Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Unified Diff: chrome/browser/android/webapps/add_to_homescreen_dialog_helper.h

Issue 2278693002: Reorder functions in add_to_homescreen_dialog_helper.cc to match order in .h file (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge branch 'master' into webapk_dialog_detector00 Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/android/webapps/add_to_homescreen_dialog_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/webapps/add_to_homescreen_dialog_helper.h
diff --git a/chrome/browser/android/webapps/add_to_homescreen_dialog_helper.h b/chrome/browser/android/webapps/add_to_homescreen_dialog_helper.h
index 296011b65785f4a9bf31a87b6829b72e01154a70..4780185c021dc67a9e47803416a3e31c7c6b4630 100644
--- a/chrome/browser/android/webapps/add_to_homescreen_dialog_helper.h
+++ b/chrome/browser/android/webapps/add_to_homescreen_dialog_helper.h
@@ -29,6 +29,9 @@ struct ShortcutInfo;
class AddToHomescreenDialogHelper :
public AddToHomescreenDataFetcher::Observer {
public:
+ // Registers JNI hooks.
+ static bool RegisterAddToHomescreenDialogHelper(JNIEnv* env);
+
AddToHomescreenDialogHelper(JNIEnv* env,
jobject obj,
content::WebContents* web_contents);
@@ -36,21 +39,11 @@ class AddToHomescreenDialogHelper :
// Called by the Java counterpart to destroy its native half.
void Destroy(JNIEnv* env, const base::android::JavaParamRef<jobject>& obj);
- // Registers JNI hooks.
- static bool RegisterAddToHomescreenDialogHelper(JNIEnv* env);
-
// Adds a shortcut to the current URL to the Android home screen.
void AddShortcut(JNIEnv* env,
const base::android::JavaParamRef<jobject>& obj,
const base::android::JavaParamRef<jstring>& title);
- // AddToHomescreenDataFetcher::Observer
- void OnUserTitleAvailable(const base::string16& user_title) override;
- void OnDataAvailable(const ShortcutInfo& info, const SkBitmap& icon) override;
- SkBitmap FinalizeLauncherIconInBackground(const SkBitmap& icon,
- const GURL& url,
- bool* is_generated) override;
-
private:
virtual ~AddToHomescreenDialogHelper();
@@ -60,6 +53,13 @@ class AddToHomescreenDialogHelper :
void RecordAddToHomescreen();
+ // AddToHomescreenDataFetcher::Observer:
+ void OnUserTitleAvailable(const base::string16& user_title) override;
+ void OnDataAvailable(const ShortcutInfo& info, const SkBitmap& icon) override;
+ SkBitmap FinalizeLauncherIconInBackground(const SkBitmap& icon,
+ const GURL& url,
+ bool* is_generated) override;
+
// Points to the Java object.
base::android::ScopedJavaGlobalRef<jobject> java_ref_;
« no previous file with comments | « no previous file | chrome/browser/android/webapps/add_to_homescreen_dialog_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698