Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2278483002:
Extending audio rendering traces on Mac with rebuffering info. (Closed)
DescriptionExtending audio rendering traces on Mac with rebuffering info.
On Mac all the rendering from the same renderer to the same device runs on the same buffer size which is a minimum of all the requested buffer sizes. FIFO is injected in case that buffer size does not match the one requested by the audio stream. Here we add tracing of the buffer mismatch.
Looks like it's a long enough explanation of 0.5 LOC change :)
TBR=dalecurtis@chromium.org
Committed: https://crrev.com/754234398ff3feabb94ff6f98e9c5b5f9dad2fb7
Cr-Commit-Position: refs/heads/master@{#414362}
Patch Set 1 #
Total comments: 2
Patch Set 2 : rename buffers sizes #Messages
Total messages: 21 (12 generated)
Description was changed from ========== Extending audio rendering traces on Mac with rebuffering info. ========== to ========== Extending audio rendering traces on Mac with rebuffering info. On Mac all the rendering from the same renderer to the same device runs on the same buffer size which is a minimum of all the requested buffer sizes. FIFO is injected in case that buffer size does not match the one requested by the audio stream. Here we add tracing of the buffer mismatch. Looks like it's a long enough explanation of 0.5 LOC change :) ==========
olka@chromium.org changed reviewers: + grunell@chromium.org, henrika@chromium.org
PTAL
https://codereview.chromium.org/2278483002/diff/1/media/audio/mac/audio_auhal... File media/audio/mac/audio_auhal_mac.cc (right): https://codereview.chromium.org/2278483002/diff/1/media/audio/mac/audio_auhal... media/audio/mac/audio_auhal_mac.cc:214: TRACE_EVENT2("audio", "AUHALStream::Render", "render buffer size", I'm bad at naming, as usual. Probably it's better to call it opposite? (Now requested - the one which comes from the platform, and render - the one we are asked to render at)
LGTM
https://codereview.chromium.org/2278483002/diff/1/media/audio/mac/audio_auhal... File media/audio/mac/audio_auhal_mac.cc (right): https://codereview.chromium.org/2278483002/diff/1/media/audio/mac/audio_auhal... media/audio/mac/audio_auhal_mac.cc:214: TRACE_EVENT2("audio", "AUHALStream::Render", "render buffer size", On 2016/08/24 10:02:43, o1ka wrote: > I'm bad at naming, as usual. Probably it's better to call it opposite? (Now > requested - the one which comes from the platform, and render - the one we are > asked to render at) Yeah, I thought it was the other way around, that requested is what the client wanted to render at. Maybe call it in and out as with the converter?
The CQ bit was checked by olka@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
olka@chromium.org changed reviewers: + dalecurtis@chromium.org
dalecurtis@ - could you RS (turned out henrika@ is an owner for Windows only)?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Extending audio rendering traces on Mac with rebuffering info. On Mac all the rendering from the same renderer to the same device runs on the same buffer size which is a minimum of all the requested buffer sizes. FIFO is injected in case that buffer size does not match the one requested by the audio stream. Here we add tracing of the buffer mismatch. Looks like it's a long enough explanation of 0.5 LOC change :) ========== to ========== Extending audio rendering traces on Mac with rebuffering info. On Mac all the rendering from the same renderer to the same device runs on the same buffer size which is a minimum of all the requested buffer sizes. FIFO is injected in case that buffer size does not match the one requested by the audio stream. Here we add tracing of the buffer mismatch. Looks like it's a long enough explanation of 0.5 LOC change :) TBR=dalecurtis@chromium.org ==========
The CQ bit was checked by olka@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from henrika@chromium.org Link to the patchset: https://codereview.chromium.org/2278483002/#ps20001 (title: "rename buffers sizes")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Extending audio rendering traces on Mac with rebuffering info. On Mac all the rendering from the same renderer to the same device runs on the same buffer size which is a minimum of all the requested buffer sizes. FIFO is injected in case that buffer size does not match the one requested by the audio stream. Here we add tracing of the buffer mismatch. Looks like it's a long enough explanation of 0.5 LOC change :) TBR=dalecurtis@chromium.org ========== to ========== Extending audio rendering traces on Mac with rebuffering info. On Mac all the rendering from the same renderer to the same device runs on the same buffer size which is a minimum of all the requested buffer sizes. FIFO is injected in case that buffer size does not match the one requested by the audio stream. Here we add tracing of the buffer mismatch. Looks like it's a long enough explanation of 0.5 LOC change :) TBR=dalecurtis@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Extending audio rendering traces on Mac with rebuffering info. On Mac all the rendering from the same renderer to the same device runs on the same buffer size which is a minimum of all the requested buffer sizes. FIFO is injected in case that buffer size does not match the one requested by the audio stream. Here we add tracing of the buffer mismatch. Looks like it's a long enough explanation of 0.5 LOC change :) TBR=dalecurtis@chromium.org ========== to ========== Extending audio rendering traces on Mac with rebuffering info. On Mac all the rendering from the same renderer to the same device runs on the same buffer size which is a minimum of all the requested buffer sizes. FIFO is injected in case that buffer size does not match the one requested by the audio stream. Here we add tracing of the buffer mismatch. Looks like it's a long enough explanation of 0.5 LOC change :) TBR=dalecurtis@chromium.org Committed: https://crrev.com/754234398ff3feabb94ff6f98e9c5b5f9dad2fb7 Cr-Commit-Position: refs/heads/master@{#414362} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/754234398ff3feabb94ff6f98e9c5b5f9dad2fb7 Cr-Commit-Position: refs/heads/master@{#414362} |
