Extending audio rendering traces on Mac with rebuffering info.

media/audio/mac/audio_auhal_mac.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/audio/mac/audio_auhal_mac.h"
 
 #include <CoreServices/CoreServices.h>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
@@ skipping 193 matching lines @@
 // Pulls on our provider to get rendered audio stream.
 // Note to future hackers of this function: Do not add locks which can
 // be contended in the middle of stream processing here (starting and stopping
 // the stream are ok) because this is running on a real-time thread.
 OSStatus AUHALStream::Render(
     AudioUnitRenderActionFlags* flags,
     const AudioTimeStamp* output_time_stamp,
     UInt32 bus_number,
     UInt32 number_of_frames,
     AudioBufferList* data) {
-  TRACE_EVENT0("audio", "AUHALStream::Render");
+  TRACE_EVENT2("audio", "AUHALStream::Render", "render buffer size",

[o1ka, 2016/08/24 10:02:43]

I'm bad at naming, as usual. Probably it's better to call it opposite? (Now
requested - the one which comes from the platform, and render - the one we are
asked to render at)

[Henrik Grunell, 2016/08/24 11:27:57]

Yeah, I thought it was the other way around, that requested is what the client
wanted to render at. Maybe call it in and out as with the converter?

+               number_of_frames_, "requested buffer size", number_of_frames);
 
   UpdatePlayoutTimestamp(output_time_stamp);
 
   // If the stream parameters change for any reason, we need to insert a FIFO
   // since the OnMoreData() pipeline can't handle frame size changes.
   if (number_of_frames != number_of_frames_) {
     // Create a FIFO on the fly to handle any discrepancies in callback rates.
     if (!audio_fifo_) {
       // TODO(grunell): We'll only care about the first buffer size change,
       // any further changes will be ignored. It would be nice to have all
@@ skipping 330 matching lines @@
   OSStatus result = AudioUnitUninitialize(audio_unit_);
   OSSTATUS_DLOG_IF(ERROR, result != noErr, result)
       << "AudioUnitUninitialize() failed.";
   result = AudioComponentInstanceDispose(audio_unit_);
   OSSTATUS_DLOG_IF(ERROR, result != noErr, result)
       << "AudioComponentInstanceDispose() failed.";
   audio_unit_ = 0;
 }
 
 }  // namespace media