Add placeholders when lists are empty for passwords and autofill.

Add placeholders when lists are empty for passwords and autofill.

BUG=608941
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/a70f33e5eda01c3e7d6b8732a3674d05dccd0ae0
Cr-Commit-Position: refs/heads/master@{#415455}

[hcarmona, 2016-08-24 22:56:48]

Description was changed from

==========
Add placeholders when lists are empty for passwords and autofill.

BUG=608941
==========

to

==========
Add placeholders when lists are empty for passwords and autofill.

BUG=608941
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[hcarmona, 2016-08-24 22:56:50]

The CQ bit was checked by hcarmona@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-24 22:58:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hcarmona, 2016-08-25 01:39:56]

hcarmona@chromium.org changed reviewers:
+ dschuyler@chromium.org

[hcarmona, 2016-08-25 01:39:57]

CL I was talking about, let me know if I need to update these to keep everything
consistent.

[commit-bot: I haz the power, 2016-08-25 01:46:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-25 01:46:18]

Dry run: This issue passed the CQ dry run.

[dschuyler, 2016-08-25 02:17:32]

Yeah, it looks like there will be some adjustments
to blend our changes together. I'm flexible about
how that happens :)

https://codereview.chromium.org/2277963002/diff/1/chrome/browser/resources/se...
File
chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.js
(right):

https://codereview.chromium.org/2277963002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.js:217:
return !!(list && list.length);
After the '&&' stage, the value will be a bool. I think the
!! would be redundant as is. Consider dropping the !!
or if you prefer, put the !! on each of the '&&' operands
list and list.length.

https://codereview.chromium.org/2277963002/diff/1/chrome/browser/resources/se...
File
chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html
(right):

https://codereview.chromium.org/2277963002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html:117:
<div class="vertical-list list-section item-list">
I've been changing item-list to list-frame and removing the list-section.
So this is something where our CLs will clash on.

https://codereview.chromium.org/2277963002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html:118:
<span id="passwordExceptionsList">
Could this id be on the div? I think I may be 
missing something subtle - can you help me
understand if the span is needed?

[hcarmona, 2016-08-26 01:13:37]

The CQ bit was checked by hcarmona@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-26 01:14:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hcarmona, 2016-08-26 01:14:52]

https://codereview.chromium.org/2277963002/diff/1/chrome/browser/resources/se...
File
chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.js
(right):

https://codereview.chromium.org/2277963002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.js:217:
return !!(list && list.length);
On 2016/08/25 02:17:32, dschuyler wrote:
> After the '&&' stage, the value will be a bool. I think the
> !! would be redundant as is. Consider dropping the !!
> or if you prefer, put the !! on each of the '&&' operands
> list and list.length.

javascript is awesome and && doesn't return boolean. ^_^

Without the !!, things will stay hidden b/c polymer expects a boolean.

https://codereview.chromium.org/2277963002/diff/1/chrome/browser/resources/se...
File
chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html
(right):

https://codereview.chromium.org/2277963002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html:117:
<div class="vertical-list list-section item-list">
On 2016/08/25 02:17:32, dschuyler wrote:
> I've been changing item-list to list-frame and removing the list-section.
> So this is something where our CLs will clash on.

I've made this CL dependent on yours.

https://codereview.chromium.org/2277963002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html:118:
<span id="passwordExceptionsList">
On 2016/08/25 02:17:32, dschuyler wrote:
> Could this id be on the div? I think I may be 
> missing something subtle - can you help me
> understand if the span is needed?

dom-repeat doesn't create a container for its items. The span is here to
hold all items for testing purposes. If we keep the id on the div, we
will have an extra item in the list when selecting it.

Only this list needs the span because the others already have a div
containing just the list.

I can make this a div or any other kind of container.

[Dan Beam, 2016-08-26 01:25:45]

https://codereview.chromium.org/2277963002/diff/1/chrome/browser/resources/se...
File
chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.js
(right):

https://codereview.chromium.org/2277963002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.js:217:
return !!(list && list.length);
On 2016/08/26 01:14:52, Hector Carmona wrote:
> On 2016/08/25 02:17:32, dschuyler wrote:
> > After the '&&' stage, the value will be a bool. I think the
> > !! would be redundant as is. Consider dropping the !!
> > or if you prefer, put the !! on each of the '&&' operands
> > list and list.length.
> 
> javascript is awesome and && doesn't return boolean. ^_^
> 
> Without the !!, things will stay hidden b/c polymer expects a boolean.

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/L...

'crazy' && 'awesome'

[dschuyler, 2016-08-26 01:36:08]

lgtm

https://codereview.chromium.org/2277963002/diff/1/chrome/browser/resources/se...
File
chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.js
(right):

https://codereview.chromium.org/2277963002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.js:217:
return !!(list && list.length);
On 2016/08/26 01:25:45, Dan Beam wrote:
> On 2016/08/26 01:14:52, Hector Carmona wrote:
> > On 2016/08/25 02:17:32, dschuyler wrote:
> > > After the '&&' stage, the value will be a bool. I think the
> > > !! would be redundant as is. Consider dropping the !!
> > > or if you prefer, put the !! on each of the '&&' operands
> > > list and list.length.
> > 
> > javascript is awesome and && doesn't return boolean. ^_^
> > 
> > Without the !!, things will stay hidden b/c polymer expects a boolean.
> 
>
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/L...
> 
> 'crazy' && 'awesome'

:(

[hcarmona, 2016-08-26 01:51:00]

The CQ bit was unchecked by hcarmona@chromium.org

[hcarmona, 2016-08-26 01:51:01]

The CQ bit was checked by hcarmona@chromium.org

[commit-bot: I haz the power, 2016-08-26 01:51:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 03:31:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-26 03:31:53]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[hcarmona, 2016-08-29 18:16:35]

The CQ bit was checked by hcarmona@chromium.org

[commit-bot: I haz the power, 2016-08-29 18:25:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 03:33:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 03:33:48]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[hcarmona, 2016-08-30 21:07:10]

The CQ bit was checked by hcarmona@chromium.org

[commit-bot: I haz the power, 2016-08-30 21:07:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 22:16:22]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-30 22:19:37]

Description was changed from

==========
Add placeholders when lists are empty for passwords and autofill.

BUG=608941
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Add placeholders when lists are empty for passwords and autofill.

BUG=608941
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/a70f33e5eda01c3e7d6b8732a3674d05dccd0ae0
Cr-Commit-Position: refs/heads/master@{#415455}
==========

[commit-bot: I haz the power, 2016-08-30 22:19:38]

Patchset 2 (id:??) landed as
https://crrev.com/a70f33e5eda01c3e7d6b8732a3674d05dccd0ae0
Cr-Commit-Position: refs/heads/master@{#415455}