Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Unified Diff: chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html

Issue 2277963002: Add placeholders when lists are empty for passwords and autofill. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Feedback and Add Tests Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html
diff --git a/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html b/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html
index 04b512eebc781843f34b633530c2b6d12a1b9634..ad630969921e595f3d462602b9685d6bcba85fe8 100644
--- a/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html
+++ b/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html
@@ -62,7 +62,8 @@
<h2>$i18n{savedPasswordsHeading}</h2>
</div>
<div class="list-frame" scrollable>
- <div class="list-item column-header">
+ <div id="savedPasswordsHeading" class="list-item column-header"
+ hidden$="[[!hasSome_(savedPasswords)]]">
<div class="website-column">$i18n{editPasswordWebsiteLabel}</div>
<div class="username-column">
$i18n{editPasswordUsernameLabel}
@@ -95,11 +96,15 @@
</div>
</template>
</iron-list>
+ <div id="noPasswordsLabel" class="list-item"
+ hidden$="[[hasSome_(savedPasswords)]]">
+ $i18n{noPasswordsFound}
+ </div>
</div>
<cr-shared-menu id="menu">
<button id="menuEditPassword" class="list-item menu-item"
on-tap="onMenuEditPasswordTap_"
- hidden="[[!showPasswords]]">$i18n{passwordViewDetails}</button>
+ hidden$="[[!showPasswords]]">$i18n{passwordViewDetails}</button>
<button id="menuRemovePassword" class="list-item menu-item"
on-tap="onMenuRemovePasswordTap_">$i18n{removePassword}</button>
</cr-shared-menu>
@@ -111,21 +116,27 @@
<div class="settings-box block first">
<h2>$i18n{passwordExceptionsHeading}</h2>
</div>
- <div id="passwordExceptionsList" class="list-frame vertical-list">
- <template is="dom-repeat" items="[[passwordExceptions]]"
- filter="[[passwordExceptionFilter_(filter)]]">
- <div class="list-item two-line">
- <div class="start">
- <a id="exception" href="[[item.linkUrl]]" target="_blank"
- class="selectable">[[item.exceptionUrl]]</a>
+ <div class="list-frame vertical-list">
+ <span id="passwordExceptionsList">
+ <template is="dom-repeat" items="[[passwordExceptions]]"
+ filter="[[passwordExceptionFilter_(filter)]]">
+ <div class="list-item two-line">
+ <div class="start">
+ <a id="exception" href="[[item.linkUrl]]" target="_blank"
+ class="selectable">[[item.exceptionUrl]]</a>
+ </div>
+ <paper-icon-button id="removeExceptionButton"
+ icon="cr:close" on-tap="onRemoveExceptionButtonTap_"
+ tabindex$="[[tabIndex]]"
+ alt="$i18n{deletePasswordException}">
+ </paper-icon-button>
</div>
- <paper-icon-button id="removeExceptionButton"
- icon="cr:close" on-tap="onRemoveExceptionButtonTap_"
- tabindex$="[[tabIndex]]"
- alt="$i18n{deletePasswordException}">
- </paper-icon-button>
- </div>
- </template>
+ </template>
+ </span>
+ <div id="noExceptionsLabel" class="list-item"
+ hidden$="[[hasSome_(passwordExceptions)]]">
+ $i18n{noExceptionsFound}
+ </div>
</div>
</template>
<script src="/passwords_and_forms_page/passwords_section.js"></script>

Powered by Google App Engine
This is Rietveld 408576698