chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js - Issue 2277963002: Add placeholders when lists are empty for passwords and autofill.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js

Issue 2277963002: Add placeholders when lists are empty for passwords and autofill. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Feedback and Add Tests Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html ('k') | chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js

diff --git a/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js b/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js

index 41dead3e9361faf9034482f052e29a45cce8d1f3..721d5eeec69fe5f18c023fd4aae70585edf4ec42 100644

--- a/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js

+++ b/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js

@@ -189,5 +189,15 @@ Polymer({

closeMenu_: function() {

/** @type {CrSharedMenuElement} */(this.$.menu).closeMenu();

+ /**

+ * Returns true if the list exists and has items.

+ * @param {Array<Object>} list

+ * @return {boolean}

+ * @private

+ */

+ hasSome_: function(list) {

+ return !!(list && list.length);

+ },

});

})();