Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2277743002: [NTP Snippets] Always show the bookmarks section, but at the end if it's empty (Closed)

Created:
4 years, 3 months ago by Marc Treib
Modified:
4 years, 3 months ago
Reviewers:
dgn
CC:
chromium-reviews, ntp-dev+reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@fix_proguard
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NTP Snippets] Always show the bookmarks section, but at the end if it's empty BUG=640568 Committed: https://crrev.com/063e6a619f3e5364c30ae4aeb4d403be3b89d8e6 Cr-Commit-Position: refs/heads/master@{#414397}

Patch Set 1 #

Patch Set 2 : fix Linux debug build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -15 lines) Patch
M components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M components/ntp_snippets/content_suggestions_service.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M components/ntp_snippets/content_suggestions_service.cc View 1 4 chunks +32 lines, -4 lines 0 comments Download
M components/ntp_snippets/content_suggestions_service_unittest.cc View 1 11 chunks +57 lines, -10 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 21 (15 generated)
Marc Treib
PTAL!
4 years, 3 months ago (2016-08-24 12:56:11 UTC) #2
Marc Treib
(This is part one of two - the "don't show the section if there are ...
4 years, 3 months ago (2016-08-24 13:31:53 UTC) #3
dgn
lgtm
4 years, 3 months ago (2016-08-24 15:55:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2277743002/20001
4 years, 3 months ago (2016-08-25 10:15:35 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-25 11:34:48 UTC) #19
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 11:36:40 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/063e6a619f3e5364c30ae4aeb4d403be3b89d8e6
Cr-Commit-Position: refs/heads/master@{#414397}

Powered by Google App Engine
This is Rietveld 408576698