Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2277523003:
[NTP Snippets] Don't show the bookmark section if there are no bookmarks at all (Closed)
|
Created:
4 years, 4 months ago by Marc Treib Modified:
4 years, 3 months ago CC:
chromium-reviews, ntp-dev+reviews_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@bookmark_empty_end Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[NTP Snippets] Don't show the bookmark section if there are no bookmarks at all
Also introduce a variation parameter to enable the "show if empty" behavior - it's off by default.
Followup to https://codereview.chromium.org/2277743002
BUG=640568
Committed: https://crrev.com/92489594f017f6383924c8326ffab7ec674557c4
Cr-Commit-Position: refs/heads/master@{#414399}
Patch Set 1 #Patch Set 2 : . #
Total comments: 2
Patch Set 3 : put behind variation param #
Total comments: 4
Patch Set 4 : review #
Depends on Patchset: Messages
Total messages: 23 (14 generated)
Description was changed from ========== [NTP Snippets] Don't show the bookmark section if there are no bookmarks at all BUG=640568 ========== to ========== [NTP Snippets] Don't show the bookmark section if there are no bookmarks at all Followup to https://codereview.chromium.org/2277743002 BUG=640568 ==========
treib@chromium.org changed reviewers: + dgn@chromium.org
...and the promised part two. This one turned out easier than expected! https://codereview.chromium.org/2277523003/diff/20001/chrome/android/java/src... File chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java (right): https://codereview.chromium.org/2277523003/diff/20001/chrome/android/java/src... chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java:195: String title, int cardLayout, boolean hasMoreButton, boolean showIfEmpty) { Unrelated, but this param was misnamed, which confused me quite a bit :)
lgtm https://codereview.chromium.org/2277523003/diff/20001/chrome/android/java/src... File chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java (right): https://codereview.chromium.org/2277523003/diff/20001/chrome/android/java/src... chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java:195: String title, int cardLayout, boolean hasMoreButton, boolean showIfEmpty) { On 2016/08/24 14:11:02, Marc Treib wrote: > Unrelated, but this param was misnamed, which confused me quite a bit :) Ah sorry, I changed names at some point and missed this bit .
Description was changed from ========== [NTP Snippets] Don't show the bookmark section if there are no bookmarks at all Followup to https://codereview.chromium.org/2277743002 BUG=640568 ========== to ========== [NTP Snippets] Don't show the bookmark section if there are no bookmarks at all Also introduce a variation parameter to enable the "show if empty" behavior - it's off by default. Followup to https://codereview.chromium.org/2277743002 BUG=640568 ==========
The CQ bit was checked by treib@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
treib@chromium.org changed reviewers: + bauerb@chromium.org
Changed product requirements again: This behavior is now behind a variation param, and off by default. Also +bauerb for owners approval.
https://codereview.chromium.org/2277523003/diff/40001/components/ntp_snippets... File components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc (right): https://codereview.chromium.org/2277523003/diff/40001/components/ntp_snippets... components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc:95: bool ShowIfEmpty() { Nit: Maybe "ShouldShowIfEmpty()" to make it clear this is not an imperative? https://codereview.chromium.org/2277523003/diff/40001/components/ntp_snippets... components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc:98: if (show_if_empty.empty() || show_if_empty == "0") If the variation parameters are strings, why not just use "true" and "false"?
https://codereview.chromium.org/2277523003/diff/40001/components/ntp_snippets... File components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc (right): https://codereview.chromium.org/2277523003/diff/40001/components/ntp_snippets... components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc:95: bool ShowIfEmpty() { On 2016/08/25 10:07:20, Bernhard Bauer wrote: > Nit: Maybe "ShouldShowIfEmpty()" to make it clear this is not an imperative? Done. https://codereview.chromium.org/2277523003/diff/40001/components/ntp_snippets... components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc:98: if (show_if_empty.empty() || show_if_empty == "0") On 2016/08/25 10:07:20, Bernhard Bauer wrote: > If the variation parameters are strings, why not just use "true" and "false"? No reason :) Done.
The CQ bit was checked by treib@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
LGTM!
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by treib@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dgn@chromium.org Link to the patchset: https://codereview.chromium.org/2277523003/#ps60001 (title: "review")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [NTP Snippets] Don't show the bookmark section if there are no bookmarks at all Also introduce a variation parameter to enable the "show if empty" behavior - it's off by default. Followup to https://codereview.chromium.org/2277743002 BUG=640568 ========== to ========== [NTP Snippets] Don't show the bookmark section if there are no bookmarks at all Also introduce a variation parameter to enable the "show if empty" behavior - it's off by default. Followup to https://codereview.chromium.org/2277743002 BUG=640568 ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== [NTP Snippets] Don't show the bookmark section if there are no bookmarks at all Also introduce a variation parameter to enable the "show if empty" behavior - it's off by default. Followup to https://codereview.chromium.org/2277743002 BUG=640568 ========== to ========== [NTP Snippets] Don't show the bookmark section if there are no bookmarks at all Also introduce a variation parameter to enable the "show if empty" behavior - it's off by default. Followup to https://codereview.chromium.org/2277743002 BUG=640568 Committed: https://crrev.com/92489594f017f6383924c8326ffab7ec674557c4 Cr-Commit-Position: refs/heads/master@{#414399} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/92489594f017f6383924c8326ffab7ec674557c4 Cr-Commit-Position: refs/heads/master@{#414399} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
