components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc - Issue 2277743002: [NTP Snippets] Always show the bookmarks section, but at the end if it's empty

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc

Issue 2277743002: [NTP Snippets] Always show the bookmarks section, but at the end if it's empty (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fix_proguard

Patch Set: fix Linux debug build Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc

diff --git a/components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc b/components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc

index a4b8c9dc348905e307758ae18aeb715b11ace28e..a8dd863f117279ebf4c886ef4b15ff29dff31a0c 100644

--- a/components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc

+++ b/components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc

@@ -151,7 +151,9 @@ CategoryInfo BookmarkSuggestionsProvider::GetCategoryInfo(Category category) {

l10n_util::GetStringUTF16(IDS_NTP_BOOKMARK_SUGGESTIONS_SECTION_HEADER),

ContentSuggestionsCardLayout::MINIMAL_CARD,

/* has_more_button */ true,

- /* show_if_empty */ false);

+ /* show_if_empty */ true);

+ // TODO(treib): Setting show_if_empty to true is a temporary hack, see

+ // crbug.com/640568.

}

void BookmarkSuggestionsProvider::DismissSuggestion(

« no previous file with comments | « no previous file | components/ntp_snippets/content_suggestions_service.h » ('j') | no next file with comments »