Handle direction control in compositor Animations

Handle direction control in compositor Animations

This patch is the compositor side. The blink side is handled in issue #178263006

Handle reverse animations in the compositor. Currently, compositor only understand alternate direction. And in order to reverse an animation, it needs to be passed a reversed timing function.

This patch introduces a Direction enum parameter in animation.

BUG=348071
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267606

[a.renevier, 2014-04-07 18:37:39]

commit was reverted in issue 220403002; create new issue to retry commit

[ajuma, 2014-04-07 20:24:56]

Are there changes from the previous version? (Do we know why the previous commit
was reverted, and if so, have those issues been addressed?)

[a.renevier, 2014-04-07 22:07:18]

On 2014/04/07 20:24:56, ajuma wrote:
> Are there changes from the previous version? (Do we know why the previous
commit
> was reverted, and if so, have those issues been addressed?)

No change from the previous version. I don't have the build failure logs. So, my
guess is that on some bots, the blink patch was applied before the chromium one.
To prevent that, I do plan to commit the blink patch long after the chromium one
(like one week maybe). Does that make sense?

[ajuma, 2014-04-07 23:04:55]

On 2014/04/07 22:07:18, a.renevier wrote:
> On 2014/04/07 20:24:56, ajuma wrote:
> > Are there changes from the previous version? (Do we know why the previous
> commit
> > was reverted, and if so, have those issues been addressed?)
> 
> No change from the previous version. I don't have the build failure logs.

Here's one of the logs:
http://build.chromium.org/p/chromium.webkit/builders/Win7%20%28dbg%29/builds/...

Note that the failure is in
webkit/renderer/compositor_bindings/web_animation_unittest.cc

To test this locally, build and run webkit_compositor_bindings_unittests.

> So, my
> guess is that on some bots, the blink patch was applied before the chromium
one.

Blink always builds with tip-of-tree chromium, so this shouldn't happen.

> To prevent that, I do plan to commit the blink patch long after the chromium
one
> (like one week maybe). Does that make sense?

You should make sure that the chromium patch has stuck (isn't getting reverted)
before landing the Blink patch, but you shouldn't need to wait a week, just wait
till the bots have cycled past your CL.

[a.renevier, 2014-04-09 18:33:40]

new patch: fixes build failure in web_animation_unittest.cc

[ajuma, 2014-04-09 18:55:44]

Thanks, lgtm.

[a.renevier, 2014-04-09 19:04:42]

The CQ bit was checked by a.renevier@samsung.com

[commit-bot: I haz the power, 2014-04-09 19:05:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/a.renevier@samsung.com/227733004/20001

[ajuma, 2014-04-09 19:06:56]

This still needs an OWNERS review for webkit/renderer/compositor_bindings.

[ajuma, 2014-04-09 19:07:01]

The CQ bit was unchecked by ajuma@chromium.org

[dstockwell, 2014-05-01 10:32:22]

Are there any webkit/renderer/compositor_bindings OWNERS who can review this?

[ajuma, 2014-05-01 14:35:07]

On 2014/05/01 10:32:22, dstockwell wrote:
> Are there any webkit/renderer/compositor_bindings OWNERS who can review this?

+enne

[enne (OOO), 2014-05-01 17:04:17]

lgtm

https://codereview.chromium.org/227733004/diff/20001/webkit/renderer/composit...
File webkit/renderer/compositor_bindings/web_animation_impl.h (right):

https://codereview.chromium.org/227733004/diff/20001/webkit/renderer/composit...
webkit/renderer/compositor_bindings/web_animation_impl.h:36: #if
WEB_ANIMATION_SUPPORTS_FULL_DIRECTION
Why the #if? It seems like you could just provide both versions and put a FIXME
to remove the deprecated alternatesDirection/setAlternatesDirection.

[a.renevier, 2014-05-01 17:10:02]

The CQ bit was checked by a.renevier@samsung.com

[commit-bot: I haz the power, 2014-05-01 17:10:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/a.renevier@samsung.com/227733004/20001

[commit-bot: I haz the power, 2014-05-01 19:25:38]

Change committed as 267606