webkit/renderer/compositor_bindings/web_animation_impl.h - Issue 227733004: Handle direction control in compositor Animations

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: webkit/renderer/compositor_bindings/web_animation_impl.h

Issue 227733004: Handle direction control in compositor Animations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: new patch: fixes build failure in web_animation_unittest.cc Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « cc/animation/animation_unittest.cc ('k') | webkit/renderer/compositor_bindings/web_animation_impl.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2012 The Chromium Authors. All rights reserved.	1 // Copyright 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef WEBKIT_RENDERER_COMPOSITOR_BINDINGS_WEB_ANIMATION_IMPL_H_	5 #ifndef WEBKIT_RENDERER_COMPOSITOR_BINDINGS_WEB_ANIMATION_IMPL_H_

6 #define WEBKIT_RENDERER_COMPOSITOR_BINDINGS_WEB_ANIMATION_IMPL_H_	6 #define WEBKIT_RENDERER_COMPOSITOR_BINDINGS_WEB_ANIMATION_IMPL_H_

7	7

8 #include "base/memory/scoped_ptr.h"	8 #include "base/memory/scoped_ptr.h"

9 #include "third_party/WebKit/public/platform/WebAnimation.h"	9 #include "third_party/WebKit/public/platform/WebAnimation.h"

10 #include "webkit/renderer/compositor_bindings/webkit_compositor_bindings_export. h"	10 #include "webkit/renderer/compositor_bindings/webkit_compositor_bindings_export. h"

(...skipping 15 matching lines...) Expand all Loading...
26	26

27 // blink::WebAnimation implementation	27 // blink::WebAnimation implementation

28 virtual int id();	28 virtual int id();

29 virtual TargetProperty targetProperty() const;	29 virtual TargetProperty targetProperty() const;

30 virtual int iterations() const;	30 virtual int iterations() const;

31 virtual void setIterations(int iterations);	31 virtual void setIterations(int iterations);

32 virtual double startTime() const;	32 virtual double startTime() const;

33 virtual void setStartTime(double monotonic_time);	33 virtual void setStartTime(double monotonic_time);

34 virtual double timeOffset() const;	34 virtual double timeOffset() const;

35 virtual void setTimeOffset(double monotonic_time);	35 virtual void setTimeOffset(double monotonic_time);

	36 #if WEB_ANIMATION_SUPPORTS_FULL_DIRECTION
	enne (OOO) 2014/05/01 17:04:18 Why the #if? It seems like you could just provide Why the #if? It seems like you could just provide both versions and put a FIXME to remove the deprecated alternatesDirection/setAlternatesDirection.
	37 virtual Direction direction() const;

	38 virtual void setDirection(Direction);

	39 #else

36 virtual bool alternatesDirection() const;	40 virtual bool alternatesDirection() const;

37 virtual void setAlternatesDirection(bool alternates);	41 virtual void setAlternatesDirection(bool alternates);

	42 #endif

38	43

39 scoped_ptr<cc::Animation> PassAnimation();	44 scoped_ptr<cc::Animation> PassAnimation();

40	45

41 private:	46 private:

42 scoped_ptr<cc::Animation> animation_;	47 scoped_ptr<cc::Animation> animation_;

43	48

44 DISALLOW_COPY_AND_ASSIGN(WebAnimationImpl);	49 DISALLOW_COPY_AND_ASSIGN(WebAnimationImpl);

45 };	50 };

46	51

47 } // namespace webkit	52 } // namespace webkit

48	53

49 #endif // WEBKIT_RENDERER_COMPOSITOR_BINDINGS_WEB_ANIMATION_IMPL_H_	54 #endif // WEBKIT_RENDERER_COMPOSITOR_BINDINGS_WEB_ANIMATION_IMPL_H_

OLD	NEW