webkit/renderer/compositor_bindings/web_animation_impl.h - Issue 227733004: Handle direction control in compositor Animations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webkit/renderer/compositor_bindings/web_animation_impl.h

Issue 227733004: Handle direction control in compositor Animations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: new patch: fixes build failure in web_animation_unittest.cc Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webkit/renderer/compositor_bindings/web_animation_impl.h

diff --git a/webkit/renderer/compositor_bindings/web_animation_impl.h b/webkit/renderer/compositor_bindings/web_animation_impl.h

index 0c248fcfce196eca9498d2b304c97b3eb8d42da9..07d72c7860c342c90356de5b4e959812eab8efd9 100644

--- a/webkit/renderer/compositor_bindings/web_animation_impl.h

+++ b/webkit/renderer/compositor_bindings/web_animation_impl.h

@@ -33,8 +33,13 @@ class WebAnimationImpl : public blink::WebAnimation {

virtual void setStartTime(double monotonic_time);

virtual double timeOffset() const;

virtual void setTimeOffset(double monotonic_time);

+#if WEB_ANIMATION_SUPPORTS_FULL_DIRECTION

enne (OOO) 2014/05/01 17:04:18 Why the #if? It seems like you could just provide

+ virtual Direction direction() const;

+ virtual void setDirection(Direction);

+#else

virtual bool alternatesDirection() const;

virtual void setAlternatesDirection(bool alternates);

+#endif

scoped_ptr<cc::Animation> PassAnimation();