Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2276973002: Revert CL 2242573002 (Closed)

Created:
4 years, 4 months ago by Raymond Toy
Modified:
4 years, 4 months ago
Reviewers:
CC:
Raymond Toy, blink-reviews, chromium-reviews, haraken, hongchan
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert CL 2242573002 https://codereview.chromium.org/2242573002 We'll do the channel interpretation and mode in a different way. TBR=hongchan@chromium.org BUG=640575, 636576 TEST=Test from 640575 passes Committed: https://crrev.com/50f926133cfbb5e2576619d1035760b027f27672 Cr-Commit-Position: refs/heads/master@{#414256}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+145 lines, -61 lines) Patch
M third_party/WebKit/Source/modules/webaudio/AudioNode.h View 2 chunks +13 lines, -27 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioNode.cpp View 7 chunks +30 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioNodeInput.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webaudio/BiquadProcessor.cpp View 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/ChannelMergerNode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webaudio/ConvolverNode.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/DefaultAudioDestinationNode.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/DeferredTaskHandler.h View 2 chunks +9 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/DeferredTaskHandler.cpp View 2 chunks +48 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/OfflineAudioDestinationNode.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/PannerNode.cpp View 3 chunks +14 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/ScriptProcessorNode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webaudio/StereoPannerNode.cpp View 3 chunks +14 lines, -5 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2276973002/1
4 years, 4 months ago (2016-08-24 17:51:17 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/280170)
4 years, 4 months ago (2016-08-24 19:24:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2276973002/1
4 years, 4 months ago (2016-08-24 19:59:12 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/280287)
4 years, 4 months ago (2016-08-24 23:26:19 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2276973002/1
4 years, 4 months ago (2016-08-25 00:13:47 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-25 02:16:36 UTC) #13
commit-bot: I haz the power
4 years, 4 months ago (2016-08-25 02:18:36 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/50f926133cfbb5e2576619d1035760b027f27672
Cr-Commit-Position: refs/heads/master@{#414256}

Powered by Google App Engine
This is Rietveld 408576698