Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 2242573002: Don't delay setting of channelInterpretation and channelCountMode (Closed)

Created:
4 years, 4 months ago by Raymond Toy
Modified:
4 years, 4 months ago
Reviewers:
hongchan
CC:
chromium-reviews, blink-reviews, haraken, Raymond Toy, hongchan
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't delay setting of channelInterpretation and channelCountMode Don't defer the setting of the values. Instead, use atomic access for these internal variables, adding appropriate getters and setters for these. This also allows us to remove the code that implemented the deferral. Ran the tests from bug 613332 to make sure we didn't regress the race conditions. Tests still pass without issues. BUG=636576 TEST=See bug 613332 for tests Committed: https://crrev.com/e3860bd297e465778059f3d845280634b4074e19 Cr-Commit-Position: refs/heads/master@{#412289}

Patch Set 1 #

Patch Set 2 : Don't need to update on interpretation change. #

Patch Set 3 : Fix grammar in comment. #

Messages

Total messages: 16 (11 generated)
Raymond Toy
PTAL
4 years, 4 months ago (2016-08-16 15:59:19 UTC) #8
hongchan
lgtm
4 years, 4 months ago (2016-08-16 16:21:37 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2242573002/40001
4 years, 4 months ago (2016-08-16 17:56:56 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-16 18:00:38 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-08-16 18:02:22 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e3860bd297e465778059f3d845280634b4074e19
Cr-Commit-Position: refs/heads/master@{#412289}

Powered by Google App Engine
This is Rietveld 408576698