Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2276923002: Remove the rest_parameter(int*) variant, use rest_parameter() instead. (Closed)

Created:
4 years, 4 months ago by neis
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com, oth, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove the rest_parameter(int*) variant, use rest_parameter() instead. The value returned via the int* argument was actually never used. Also remove has_rest_parameter() in favor of returning nullptr from rest_parameter(). This is in line with similar accessors and simplifies my changes. BUG= Committed: https://crrev.com/615aea66e80ed6e44f8fc4e6f7842d90d02f97d2 Cr-Commit-Position: refs/heads/master@{#38868}

Patch Set 1 #

Patch Set 2 : Ports. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -73 lines) Patch
M src/ast/ast-numbering.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/ast/scopes.h View 1 chunk +8 lines, -26 lines 0 comments Download
M src/ast/scopes.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/compiler/ast-graph-builder.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
M src/full-codegen/s390/full-codegen-s390.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
M src/interpreter/bytecode-generator.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
neis
PTAL
4 years, 4 months ago (2016-08-24 11:55:53 UTC) #3
Benedikt Meurer
LGTM.
4 years, 4 months ago (2016-08-24 12:08:21 UTC) #4
Toon Verwaest
lgtm
4 years, 4 months ago (2016-08-24 14:19:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2276923002/20001
4 years, 4 months ago (2016-08-24 14:21:19 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-24 14:44:48 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-24 14:45:15 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/615aea66e80ed6e44f8fc4e6f7842d90d02f97d2
Cr-Commit-Position: refs/heads/master@{#38868}

Powered by Google App Engine
This is Rietveld 408576698