Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: src/ast/scopes.cc

Issue 2276923002: Remove the rest_parameter(int*) variant, use rest_parameter() instead. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Ports. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/ast/scopes.h ('k') | src/compiler/ast-graph-builder.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ast/scopes.cc
diff --git a/src/ast/scopes.cc b/src/ast/scopes.cc
index 2a41c7d47a2c1a458422e4f1225b24bd080b8567..b8f51973b8a65fd6fdd94014b626583182031acd 100644
--- a/src/ast/scopes.cc
+++ b/src/ast/scopes.cc
@@ -680,7 +680,7 @@ Variable* DeclarationScope::DeclareParameter(
bool* is_duplicate, AstValueFactory* ast_value_factory) {
DCHECK(!already_resolved_);
DCHECK(is_function_scope());
- DCHECK(!has_rest_parameter());
+ DCHECK(!has_rest_);
DCHECK(!is_optional || !is_rest);
Variable* var;
if (mode == TEMPORARY) {
@@ -1493,7 +1493,7 @@ void DeclarationScope::AllocateParameterLocals() {
// order is relevant!
for (int i = num_parameters() - 1; i >= 0; --i) {
Variable* var = params_[i];
- DCHECK(!has_rest_parameter() || var != rest_parameter());
+ DCHECK(!has_rest_ || var != rest_parameter());
DCHECK_EQ(this, var->scope());
if (uses_sloppy_arguments) {
var->ForceContextAllocation();
@@ -1586,7 +1586,7 @@ void DeclarationScope::AllocateLocals() {
AllocateNonParameterLocal(function_);
}
- DCHECK(!has_rest_parameter() || !MustAllocate(rest_parameter()) ||
+ DCHECK(!has_rest_ || !MustAllocate(rest_parameter()) ||
!rest_parameter()->IsUnallocated());
if (new_target_ != nullptr && !MustAllocate(new_target_)) {
« no previous file with comments | « src/ast/scopes.h ('k') | src/compiler/ast-graph-builder.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698