Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Unified Diff: src/crankshaft/hydrogen.cc

Issue 2276923002: Remove the rest_parameter(int*) variant, use rest_parameter() instead. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Ports. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/ast-graph-builder.cc ('k') | src/full-codegen/arm/full-codegen-arm.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/crankshaft/hydrogen.cc
diff --git a/src/crankshaft/hydrogen.cc b/src/crankshaft/hydrogen.cc
index 240101eeebdb377c24e2963efb15410af7284ce4..95f2d7a153e885a20b6c954c565df4fc5dc792d5 100644
--- a/src/crankshaft/hydrogen.cc
+++ b/src/crankshaft/hydrogen.cc
@@ -4651,9 +4651,7 @@ void HOptimizedGraphBuilder::SetUpScope(DeclarationScope* scope) {
environment()->Bind(scope->arguments(), arguments_object);
}
- int rest_index;
- Variable* rest = scope->rest_parameter(&rest_index);
- if (rest) {
+ if (scope->rest_parameter() != nullptr) {
return Bailout(kRestParameter);
}
@@ -8406,9 +8404,7 @@ bool HOptimizedGraphBuilder::TryInline(Handle<JSFunction> target,
return false;
}
- int rest_index;
- Variable* rest = target_info.scope()->rest_parameter(&rest_index);
- if (rest) {
+ if (target_info.scope()->rest_parameter() != nullptr) {
TraceInline(target, caller, "target uses rest parameters");
return false;
}
« no previous file with comments | « src/compiler/ast-graph-builder.cc ('k') | src/full-codegen/arm/full-codegen-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698