Improve accuracy of detecting type trait fields.

Improve accuracy of detecting type trait fields.

BUG=640749
Committed: https://crrev.com/a6f1e34b68538cffadd8e0b7636e1128c092bcb0
Cr-Commit-Position: refs/heads/master@{#414557}

[Łukasz Anforowicz, 2016-08-24 21:21:15]

lukasza@chromium.org changed reviewers:
+ dcheng@chromium.org

[Łukasz Anforowicz, 2016-08-24 21:21:16]

Daniel, can you take a look please?

[dcheng, 2016-08-24 21:42:17]

https://codereview.chromium.org/2276813003/diff/1/tools/clang/rewrite_to_chro...
File tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp (right):

https://codereview.chromium.org/2276813003/diff/1/tools/clang/rewrite_to_chro...
tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp:458:
hasName("WTF"), hasParent(translationUnitDecl()))))));
Since this is expressed as a matcher now, should we just move it into
field_decl_matcher?

[Łukasz Anforowicz, 2016-08-24 21:55:09]

https://codereview.chromium.org/2276813003/diff/1/tools/clang/rewrite_to_chro...
File tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp (right):

https://codereview.chromium.org/2276813003/diff/1/tools/clang/rewrite_to_chro...
tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp:458:
hasName("WTF"), hasParent(translationUnitDecl()))))));
On 2016/08/24 21:42:17, dcheng wrote:
> Since this is expressed as a matcher now, should we just move it into
> field_decl_matcher?

Good point.  Done.  (although this has to go to |var_decl_matcher| - I think
static fields are varDecls, not fieldDecls (which I think only cover instance
fields?  I might be confused here...).

[Łukasz Anforowicz, 2016-08-24 22:36:21]

https://codereview.chromium.org/2276813003/diff/20001/tools/clang/rewrite_to_...
File tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp (right):

https://codereview.chromium.org/2276813003/diff/20001/tools/clang/rewrite_to_...
tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp:842:
hasName("value"), hasStaticStorageDuration(),
BTW: All static fields in wtf/TypeTraits.h are named "value".  I assume that
restricting the skipping to fields named "value" is okay, because other things
(e.g. safeToCompareToEmptyOrDeleted that https://crbug.com/598177 talks about)
are not really type traits.

FWIW, the current code results in wtf:wtf_unittests target building fine after
running the renaming tool.

[dcheng, 2016-08-25 03:05:33]

LGTM with comments addressed.

https://codereview.chromium.org/2276813003/diff/20001/tools/clang/rewrite_to_...
File tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp (right):

https://codereview.chromium.org/2276813003/diff/20001/tools/clang/rewrite_to_...
tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp:841:
unless(varDecl(  // Unless it is a type trait's static value.
I'd recommend capturing the varDecl(hasName("value", ...) matcher into its own
variable (is_wtf_type_trait_value, perhaps) and then just using it in here.

[Łukasz Anforowicz, 2016-08-25 21:31:41]

https://codereview.chromium.org/2276813003/diff/20001/tools/clang/rewrite_to_...
File tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp (right):

https://codereview.chromium.org/2276813003/diff/20001/tools/clang/rewrite_to_...
tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp:841:
unless(varDecl(  // Unless it is a type trait's static value.
On 2016/08/25 03:05:33, dcheng wrote:
> I'd recommend capturing the varDecl(hasName("value", ...) matcher into its own
> variable (is_wtf_type_trait_value, perhaps) and then just using it in here.

Done.

[Łukasz Anforowicz, 2016-08-25 21:31:44]

The CQ bit was checked by lukasza@chromium.org

[Łukasz Anforowicz, 2016-08-25 21:31:45]

The patchset sent to the CQ was uploaded after l-g-t-m from dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2276813003/#ps60001
(title: "Moving part of a matcher into a separate |is_wtf_type_trait_value|
variable.")

[commit-bot: I haz the power, 2016-08-25 21:33:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 22:20:40]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-25 22:23:05]

Description was changed from

==========
Improve accuracy of detecting type trait fields.

BUG=640749
==========

to

==========
Improve accuracy of detecting type trait fields.

BUG=640749

Committed: https://crrev.com/a6f1e34b68538cffadd8e0b7636e1128c092bcb0
Cr-Commit-Position: refs/heads/master@{#414557}
==========

[commit-bot: I haz the power, 2016-08-25 22:23:06]

Patchset 4 (id:??) landed as
https://crrev.com/a6f1e34b68538cffadd8e0b7636e1128c092bcb0
Cr-Commit-Position: refs/heads/master@{#414557}