Replace clang::tooling::Replacements with std::set<clang::tooling::Replacement>.

Replace clang::tooling::Replacements with std::set<clang::tooling::Replacement>.

Most recent clang roll brought in
https://github.com/llvm-mirror/clang/commit/85c0fa18d965d4ed91e037a085e4c20bcea7e27f
which changed clang::tooling::Replacements from being a type alias for
std::set<Replacement> to being a standalone class.  This means that there is no
Replacements::emplace anymore.

In theory calls to Replacements::emplace could be replaced with
calls to Replacements::add, but in practice the add call fails with:

1) All replacements must have the same file path. New replacement:
   ../../third_party/WebKit/Source/wtf/TypeTraits.h, existing
   replacements: ../../third_party/WebKit/Source/wtf/Assertions.h

or

2) New replacement:
   .../tools/clang/rewrite_to_chrome_style/tests/methods-actual.cc:
   2635:+5:"ptr_" conflicts with existing replacement:
   .../tools/clang/rewrite_to_chrome_style/tests/methods-actual.cc:
   2635:+5:"ptr_"

So - the easiest fix seems to be to just directly use
std::set<clang::tooling::Replacement>.

BUG=

Committed: https://crrev.com/e88f48501ee8744d8b0b39995b61fcb12cd304a8
Cr-Commit-Position: refs/heads/master@{#412379}

[Łukasz Anforowicz, 2016-08-16 21:24:34]

lukasza@chromium.org changed reviewers:
+ dcheng@chromium.org

[Łukasz Anforowicz, 2016-08-16 21:24:35]

dcheng@, PTAL?

I guess the rewrite tool is not part of CQ and this is why the most recent clang
roll (r410289 from thakis@) could land, even though it breaks the tool.

[Łukasz Anforowicz, 2016-08-16 22:24:16]

dcheng@ - in patchset #3 the tools/clang/rewrite_to_chrome_style/tests are
green.  Can you take a look please?

https://codereview.chromium.org/2252853002/diff/40001/tools/clang/rewrite_to_...
File tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp (right):

https://codereview.chromium.org/2252853002/diff/40001/tools/clang/rewrite_to_...
tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp:502: return
new_replacement.toString() == old_replacement.toString();
Replacement doesn't define ==.  And Replacements doesn't have |contains| or
|find| method.  Therefore - I end up with an ugly std::any_of and with
x.toString() == y.toString().  :-(

https://codereview.chromium.org/2252853002/diff/40001/tools/clang/rewrite_to_...
tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp:505: return;
If we didn't check |is_same_replacement_already_present|, then the new
|Replacements::add| method would fail saying (in |err.toString()|) something
like:

New replacement:
/usr/local/google/home/lukasza/src/chromium4/src/tools/clang/rewrite_to_chrome_style/tests/methods-actual.cc:
2635:+5:"ptr_"
conflicts with existing replacement:
/usr/local/google/home/lukasza/src/chromium4/src/tools/clang/rewrite_to_chrome_style/tests/methods-actual.cc:
2635:+5:"ptr_"

https://codereview.chromium.org/2252853002/diff/40001/tools/clang/rewrite_to_...
tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp:512: return;
I am not sure how I should spell a fatal failure...

[Łukasz Anforowicz, 2016-08-16 22:42:46]

Description was changed from

==========
Replace calls to Replacements::emplace with calls to Replacements::add.

Most recent clang roll brought in
https://github.com/llvm-mirror/clang/commit/85c0fa18d965d4ed91e037a085e4c20bc...
which changed clang::tooling::Replacements from being a type alias for
std::set<Replacement> to being a standalone class.  This means that
calls to Replacements::emplace have to be replaced with calls to
Replacements::add.

BUG=
==========

to

==========
Replace clang::tooling::Replacements with std::set<clang::tooling::Replacement>.

Most recent clang roll brought in
https://github.com/llvm-mirror/clang/commit/85c0fa18d965d4ed91e037a085e4c20bc...
which changed clang::tooling::Replacements from being a type alias for
std::set<Replacement> to being a standalone class.  This means that there is no
Replacements::emplace anymore.

In theory calls to Replacements::emplace could be replaced with
calls to Replacements::add, but in practice the add call fails with:

1) All replacements must have the same file path. New replacement:
   ../../third_party/WebKit/Source/wtf/TypeTraits.h, existing
   replacements: ../../third_party/WebKit/Source/wtf/Assertions.h

or

2) New replacement:
   .../tools/clang/rewrite_to_chrome_style/tests/methods-actual.cc:
   2635:+5:"ptr_" conflicts with existing replacement:
   .../tools/clang/rewrite_to_chrome_style/tests/methods-actual.cc:
   2635:+5:"ptr_"

So - the easiest fix seems to be to just directly use
std::set<clang::tooling::Replacement>.

BUG=
==========

[dcheng, 2016-08-16 23:04:44]

LGTM. We might still want to use the clang tooling thing as some point, but
unbreaking the compile seems like the most expedient thing for now.

[Łukasz Anforowicz, 2016-08-16 23:06:03]

The CQ bit was checked by lukasza@chromium.org

[commit-bot: I haz the power, 2016-08-16 23:06:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-16 23:45:53]

Description was changed from

==========
Replace clang::tooling::Replacements with std::set<clang::tooling::Replacement>.

Most recent clang roll brought in
https://github.com/llvm-mirror/clang/commit/85c0fa18d965d4ed91e037a085e4c20bc...
which changed clang::tooling::Replacements from being a type alias for
std::set<Replacement> to being a standalone class.  This means that there is no
Replacements::emplace anymore.

In theory calls to Replacements::emplace could be replaced with
calls to Replacements::add, but in practice the add call fails with:

1) All replacements must have the same file path. New replacement:
   ../../third_party/WebKit/Source/wtf/TypeTraits.h, existing
   replacements: ../../third_party/WebKit/Source/wtf/Assertions.h

or

2) New replacement:
   .../tools/clang/rewrite_to_chrome_style/tests/methods-actual.cc:
   2635:+5:"ptr_" conflicts with existing replacement:
   .../tools/clang/rewrite_to_chrome_style/tests/methods-actual.cc:
   2635:+5:"ptr_"

So - the easiest fix seems to be to just directly use
std::set<clang::tooling::Replacement>.

BUG=
==========

to

==========
Replace clang::tooling::Replacements with std::set<clang::tooling::Replacement>.

Most recent clang roll brought in
https://github.com/llvm-mirror/clang/commit/85c0fa18d965d4ed91e037a085e4c20bc...
which changed clang::tooling::Replacements from being a type alias for
std::set<Replacement> to being a standalone class.  This means that there is no
Replacements::emplace anymore.

In theory calls to Replacements::emplace could be replaced with
calls to Replacements::add, but in practice the add call fails with:

1) All replacements must have the same file path. New replacement:
   ../../third_party/WebKit/Source/wtf/TypeTraits.h, existing
   replacements: ../../third_party/WebKit/Source/wtf/Assertions.h

or

2) New replacement:
   .../tools/clang/rewrite_to_chrome_style/tests/methods-actual.cc:
   2635:+5:"ptr_" conflicts with existing replacement:
   .../tools/clang/rewrite_to_chrome_style/tests/methods-actual.cc:
   2635:+5:"ptr_"

So - the easiest fix seems to be to just directly use
std::set<clang::tooling::Replacement>.

BUG=
==========

[commit-bot: I haz the power, 2016-08-16 23:45:55]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-16 23:48:35]

Description was changed from

==========
Replace clang::tooling::Replacements with std::set<clang::tooling::Replacement>.

Most recent clang roll brought in
https://github.com/llvm-mirror/clang/commit/85c0fa18d965d4ed91e037a085e4c20bc...
which changed clang::tooling::Replacements from being a type alias for
std::set<Replacement> to being a standalone class.  This means that there is no
Replacements::emplace anymore.

In theory calls to Replacements::emplace could be replaced with
calls to Replacements::add, but in practice the add call fails with:

1) All replacements must have the same file path. New replacement:
   ../../third_party/WebKit/Source/wtf/TypeTraits.h, existing
   replacements: ../../third_party/WebKit/Source/wtf/Assertions.h

or

2) New replacement:
   .../tools/clang/rewrite_to_chrome_style/tests/methods-actual.cc:
   2635:+5:"ptr_" conflicts with existing replacement:
   .../tools/clang/rewrite_to_chrome_style/tests/methods-actual.cc:
   2635:+5:"ptr_"

So - the easiest fix seems to be to just directly use
std::set<clang::tooling::Replacement>.

BUG=
==========

to

==========
Replace clang::tooling::Replacements with std::set<clang::tooling::Replacement>.

Most recent clang roll brought in
https://github.com/llvm-mirror/clang/commit/85c0fa18d965d4ed91e037a085e4c20bc...
which changed clang::tooling::Replacements from being a type alias for
std::set<Replacement> to being a standalone class.  This means that there is no
Replacements::emplace anymore.

In theory calls to Replacements::emplace could be replaced with
calls to Replacements::add, but in practice the add call fails with:

1) All replacements must have the same file path. New replacement:
   ../../third_party/WebKit/Source/wtf/TypeTraits.h, existing
   replacements: ../../third_party/WebKit/Source/wtf/Assertions.h

or

2) New replacement:
   .../tools/clang/rewrite_to_chrome_style/tests/methods-actual.cc:
   2635:+5:"ptr_" conflicts with existing replacement:
   .../tools/clang/rewrite_to_chrome_style/tests/methods-actual.cc:
   2635:+5:"ptr_"

So - the easiest fix seems to be to just directly use
std::set<clang::tooling::Replacement>.

BUG=

Committed: https://crrev.com/e88f48501ee8744d8b0b39995b61fcb12cd304a8
Cr-Commit-Position: refs/heads/master@{#412379}
==========

[commit-bot: I haz the power, 2016-08-16 23:48:36]

Patchset 4 (id:??) landed as
https://crrev.com/e88f48501ee8744d8b0b39995b61fcb12cd304a8
Cr-Commit-Position: refs/heads/master@{#412379}