Improve accuracy of detecting type trait fields.

tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // Changes Blink-style names to Chrome-style names. Currently transforms:
 //   fields:
 //     int m_operationCount => int operation_count_
 //   variables (including parameters):
 //     int mySuperVariable => int my_super_variable
 //   constants:
@@ skipping 83 matching lines @@
   if (Node.getNumDecls() == 0)
     return false;
 
   for (clang::NamedDecl* decl : Node.decls()) {
     if (!InnerMatcher.matches(*decl, Finder, Builder))
       return false;
   }
   return true;
 }
 
-bool IsDeclContextInWTF(const clang::DeclContext* decl_context) {
-  auto* namespace_decl = clang::dyn_cast_or_null<clang::NamespaceDecl>(
-      decl_context->getEnclosingNamespaceContext());
-  if (!namespace_decl)
-    return false;
-  if (namespace_decl->getParent()->isTranslationUnit() &&
-      namespace_decl->getName() == "WTF")
-    return true;
-  return IsDeclContextInWTF(namespace_decl->getParent());
-}
-
 template <typename T>
 bool MatchAllOverriddenMethods(
     const clang::CXXMethodDecl& decl,
     T&& inner_matcher,
     clang::ast_matchers::internal::ASTMatchFinder* finder,
     clang::ast_matchers::internal::BoundNodesTreeBuilder* builder) {
   bool override_matches = false;
   bool override_not_matches = false;
 
   for (auto it = decl.begin_overridden_methods();
@@ skipping 321 matching lines @@
   // static class members match against VarDecls. Blink style dictates that
   // these should be prefixed with `s_`, so strip that off. Also check for `m_`
   // and strip that off too, for code that accidentally uses the wrong prefix.
   if (original_name.startswith(kBlinkStaticMemberPrefix))
     original_name = original_name.substr(strlen(kBlinkStaticMemberPrefix));
   else if (original_name.startswith(kBlinkFieldPrefix))
     original_name = original_name.substr(strlen(kBlinkFieldPrefix));
 
   bool is_const = IsProbablyConst(decl, context);
   if (is_const) {
-    // Struct consts in WTF do not become kFoo cuz stuff like type traits
-    // should stay as lowercase.
-    const clang::DeclContext* decl_context = decl.getDeclContext();
-    bool is_in_wtf = IsDeclContextInWTF(decl_context);
-    const clang::CXXRecordDecl* parent =
-        clang::dyn_cast_or_null<clang::CXXRecordDecl>(decl_context);
-    if (is_in_wtf && parent && parent->isStruct())
-      return false;
-
     if (!GetNameForConstant(original_name.str(), name))
       return false;
   } else {
     name = CamelCaseToUnderscoreCase(original_name);
 
     // Non-const variables with static storage duration at namespace scope are
     // prefixed with `g_' to reduce the likelihood of a naming collision.
     const clang::DeclContext* decl_context = decl.getDeclContext();
     if (name.find("g_") != 0 && decl.hasGlobalStorage() &&
         decl_context->isNamespace())
@@ skipping 373 matching lines @@
 
   // Field, variable, and enum declarations ========
   // Given
   //   int x;
   //   struct S {
   //     int y;
   //     enum { VALUE };
   //   };
   // matches |x|, |y|, and |VALUE|.
   auto field_decl_matcher = id("decl", fieldDecl(in_blink_namespace));
-  auto var_decl_matcher = id("decl", varDecl(in_blink_namespace));
+  auto var_decl_matcher = id(
+      "decl",
+      varDecl(in_blink_namespace,
+              unless(varDecl(  // Unless it is a type trait's static value.

[dcheng, 2016/08/25 03:05:33]

I'd recommend capturing the varDecl(hasName("value", ...) matcher into its own
variable (is_wtf_type_trait_value, perhaps) and then just using it in here.

[Łukasz Anforowicz, 2016/08/25 21:31:41]

Done.

+                  hasName("value"), hasStaticStorageDuration(),

[Łukasz Anforowicz, 2016/08/24 22:36:20]

BTW: All static fields in wtf/TypeTraits.h are named "value".  I assume that
restricting the skipping to fields named "value" is okay, because other things
(e.g. safeToCompareToEmptyOrDeleted that https://crbug.com/598177 talks about)
are not really type traits.

FWIW, the current code results in wtf:wtf_unittests target building fine after
running the renaming tool.

+                  hasType(isConstQualified()), hasType(booleanType()),
+                  hasAncestor(recordDecl(hasAncestor(namespaceDecl(
+                      hasName("WTF"), hasParent(translationUnitDecl())))))))));
   auto enum_member_decl_matcher =
       id("decl", enumConstantDecl(in_blink_namespace));
 
   FieldDeclRewriter field_decl_rewriter(&replacements);
   match_finder.addMatcher(field_decl_matcher, &field_decl_rewriter);
 
   VarDeclRewriter var_decl_rewriter(&replacements);
   match_finder.addMatcher(var_decl_matcher, &var_decl_rewriter);
 
   EnumConstantDeclRewriter enum_member_decl_rewriter(&replacements);
@@ skipping 341 matching lines @@
   for (const auto& r : replacements) {
     std::string replacement_text = r.getReplacementText().str();
     std::replace(replacement_text.begin(), replacement_text.end(), '\n', '\0');
     llvm::outs() << "r:::" << r.getFilePath() << ":::" << r.getOffset()
                  << ":::" << r.getLength() << ":::" << replacement_text << "\n";
   }
   llvm::outs() << "==== END EDITS ====\n";
 
   return 0;
 }