Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 2276433003: Remove a Platform::current() check from Mojo's error handler in WebSocket (Closed)

Created:
4 years, 4 months ago by haraken
Modified:
4 years, 3 months ago
Reviewers:
yhirano
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove a Platform::current() check from Mojo's error handler in WebSocket The check was added in https://codereview.chromium.org/2258003003/ but is no longer needed because I already removed blink::shutdown from renderer's shutdown sequence. BUG=637949, 639244 Committed: https://crrev.com/9a8f5c73b4158495cf3e35aee83e1e2b2fc7cb9c Cr-Commit-Position: refs/heads/master@{#415196}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -9 lines) Patch
M content/renderer/websockethandle_impl.cc View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
haraken
PTAL
4 years, 4 months ago (2016-08-24 07:18:41 UTC) #3
yhirano
lgtm Is the shutdown change stable? I thought about removing the check after the branch ...
4 years, 4 months ago (2016-08-24 07:22:30 UTC) #5
haraken
> Is the shutdown change stable? I thought about removing the check after the > ...
4 years, 4 months ago (2016-08-24 07:25:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2276433003/1
4 years, 3 months ago (2016-08-29 21:49:12 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-30 06:03:55 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9a8f5c73b4158495cf3e35aee83e1e2b2fc7cb9c Cr-Commit-Position: refs/heads/master@{#415196}
4 years, 3 months ago (2016-08-30 06:06:11 UTC) #13
haraken
4 years, 3 months ago (2016-09-05 00:29:10 UTC) #15
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2312573002/ by haraken@chromium.org.

The reason for reverting is: I'll revert r413430 and its dependent CLs because
r413430 caused issue 642072.

The problem is that we cannot simply remove blink::shutdown because the
following scenario can happen:

1) blink::shutdown is not called. Workers are still running.
2) RenderThreadImpl gets destructed. MessageLoop gets destructed.
3) The workers may access the RenderThreadImpl and MessageLoop.

To fix the problem, we need to call ProcessDied() and forcibly kill the renderer
process at the end of RenderThreadImpl::Shutdown().
.

Powered by Google App Engine
This is Rietveld 408576698