Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2276013002: [NTP Snippets] Fix crash when clicking on a native-page suggestion (Closed)

Created:
4 years, 4 months ago by Marc Treib
Modified:
4 years, 4 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, ntp-dev+reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@fix_proguard
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NTP Snippets] Fix crash when clicking on a native-page suggestion Opening a native page (e.g. Bookmarks, Recent Tabs) causes the NewTabPage instance to be destroyed immediately, so do that *after* calling tracking methods etc. BUG=640543 Committed: https://crrev.com/53f0240ae041bcb9e28d82b2a8b99121afeff388 Cr-Commit-Position: refs/heads/master@{#414071}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
Marc Treib
PTAL!
4 years, 4 months ago (2016-08-24 14:21:05 UTC) #4
Bernhard Bauer
lgtm
4 years, 4 months ago (2016-08-24 14:30:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2276013002/1
4 years, 4 months ago (2016-08-24 14:36:40 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-24 14:58:45 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-24 15:00:17 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/53f0240ae041bcb9e28d82b2a8b99121afeff388
Cr-Commit-Position: refs/heads/master@{#414071}

Powered by Google App Engine
This is Rietveld 408576698