Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Side by Side Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java

Issue 2276013002: [NTP Snippets] Fix crash when clicking on a native-page suggestion (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fix_proguard
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package org.chromium.chrome.browser.ntp; 5 package org.chromium.chrome.browser.ntp;
6 6
7 import android.annotation.TargetApi; 7 import android.annotation.TargetApi;
8 import android.content.Context; 8 import android.content.Context;
9 import android.graphics.Canvas; 9 import android.graphics.Canvas;
10 import android.graphics.Point; 10 import android.graphics.Point;
(...skipping 278 matching lines...) Expand 10 before | Expand all | Expand 10 after
289 } 289 }
290 290
291 @Override 291 @Override
292 public void trackSnippetMenuOpened(SnippetArticle article) { 292 public void trackSnippetMenuOpened(SnippetArticle article) {
293 mSnippetsBridge.onSuggestionMenuOpened(article.mGlobalPosition, arti cle.mCategory, 293 mSnippetsBridge.onSuggestionMenuOpened(article.mGlobalPosition, arti cle.mCategory,
294 article.mPosition, article.mPublishTimestampMilliseconds, ar ticle.mScore); 294 article.mPosition, article.mPublishTimestampMilliseconds, ar ticle.mScore);
295 } 295 }
296 296
297 @Override 297 @Override
298 public void openSnippet(int windowOpenDisposition, SnippetArticle articl e) { 298 public void openSnippet(int windowOpenDisposition, SnippetArticle articl e) {
299 openUrl(windowOpenDisposition, article.mUrl);
300 mSnippetsBridge.onSuggestionOpened(article.mGlobalPosition, article. mCategory, 299 mSnippetsBridge.onSuggestionOpened(article.mGlobalPosition, article. mCategory,
301 article.mPosition, article.mPublishTimestampMilliseconds, ar ticle.mScore, 300 article.mPosition, article.mPublishTimestampMilliseconds, ar ticle.mScore,
302 windowOpenDisposition); 301 windowOpenDisposition);
303 NewTabPageUma.monitorContentSuggestionVisit(mTab, article.mCategory) ; 302 NewTabPageUma.monitorContentSuggestionVisit(mTab, article.mCategory) ;
303 openUrl(windowOpenDisposition, article.mUrl);
304 } 304 }
305 305
306 private void openUrl(int windowOpenDisposition, String url) { 306 private void openUrl(int windowOpenDisposition, String url) {
307 assert !mIsDestroyed; 307 assert !mIsDestroyed;
308 switch (windowOpenDisposition) { 308 switch (windowOpenDisposition) {
309 case WindowOpenDisposition.CURRENT_TAB: 309 case WindowOpenDisposition.CURRENT_TAB:
310 mTab.loadUrl(new LoadUrlParams(url, PageTransition.AUTO_BOOK MARK)); 310 mTab.loadUrl(new LoadUrlParams(url, PageTransition.AUTO_BOOK MARK));
311 break; 311 break;
312 case WindowOpenDisposition.NEW_FOREGROUND_TAB: 312 case WindowOpenDisposition.NEW_FOREGROUND_TAB:
313 openUrlInNewTab(url, false); 313 openUrlInNewTab(url, false);
(...skipping 588 matching lines...) Expand 10 before | Expand all | Expand 10 after
902 @Override 902 @Override
903 public boolean shouldCaptureThumbnail() { 903 public boolean shouldCaptureThumbnail() {
904 return mNewTabPageView.shouldCaptureThumbnail(); 904 return mNewTabPageView.shouldCaptureThumbnail();
905 } 905 }
906 906
907 @Override 907 @Override
908 public void captureThumbnail(Canvas canvas) { 908 public void captureThumbnail(Canvas canvas) {
909 mNewTabPageView.captureThumbnail(canvas); 909 mNewTabPageView.captureThumbnail(canvas);
910 } 910 }
911 } 911 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698