Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java

Issue 2276013002: [NTP Snippets] Fix crash when clicking on a native-page suggestion (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fix_proguard
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
index 7ec1edc5e870201551a9298aca7f366edd5f02c6..3d136ef9825379965e1902dfc9d85bb39669a4b8 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
@@ -296,11 +296,11 @@ public class NewTabPage
@Override
public void openSnippet(int windowOpenDisposition, SnippetArticle article) {
- openUrl(windowOpenDisposition, article.mUrl);
mSnippetsBridge.onSuggestionOpened(article.mGlobalPosition, article.mCategory,
article.mPosition, article.mPublishTimestampMilliseconds, article.mScore,
windowOpenDisposition);
NewTabPageUma.monitorContentSuggestionVisit(mTab, article.mCategory);
+ openUrl(windowOpenDisposition, article.mUrl);
}
private void openUrl(int windowOpenDisposition, String url) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698