[Offline Pages] Don't remove user-requested pages when deleting cache.

[Offline Pages] Don't remove user-requested pages when deleting cache.

When deleting cache in settings, the user-requested pages shouldn't be
deleted. Adding a check for namespace in the method called by browsing
data remover, filtering out the user-requested pages.

BUG=640416
Committed: https://crrev.com/66a4eb704d562fb4791ac7b84c1d45ce2756e62f
Cr-Commit-Position: refs/heads/master@{#414180}

[romax, 2016-08-24 00:58:11]

romax@chromium.org changed reviewers:
+ dimich@chromium.org, msramek@chromium.org

[romax, 2016-08-24 00:58:12]

msramek@chromium.org: Please review changes in c/b/browsing_data

dimich@chromium.org: Please review changes in components/offline_pages/

[romax, 2016-08-24 00:58:22]

The CQ bit was checked by romax@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-24 00:59:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dmitry Titov, 2016-08-24 01:07:15]

lgtm, thanks!

[commit-bot: I haz the power, 2016-08-24 02:05:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 02:05:48]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[msramek, 2016-08-24 09:12:10]

Code-wise LGTM, but just to confirm:

The pages we're not deleting are the ones that will be treated like downloads,
and will be accessible from the downloads page?

[fgorski, 2016-08-24 16:22:03]

fgorski@chromium.org changed reviewers:
+ fgorski@chromium.org

[fgorski, 2016-08-24 16:22:04]

lgtm with suggestion to rename a method.

https://codereview.chromium.org/2275833002/diff/1/components/offline_pages/of...
File components/offline_pages/offline_page_model_impl.cc (right):

https://codereview.chromium.org/2275833002/diff/1/components/offline_pages/of...
components/offline_pages/offline_page_model_impl.cc:1064: bool
OfflinePageModelImpl::IsPageUserRequested(
IsUserRequestedPage

[romax, 2016-08-24 17:26:22]

msramek@, yes the user initiated offline pages will show as part of downloads.

Changed the name of the helper function. ready to commit.

Thanks!

https://codereview.chromium.org/2275833002/diff/1/components/offline_pages/of...
File components/offline_pages/offline_page_model_impl.cc (right):

https://codereview.chromium.org/2275833002/diff/1/components/offline_pages/of...
components/offline_pages/offline_page_model_impl.cc:1064: bool
OfflinePageModelImpl::IsPageUserRequested(
On 2016/08/24 16:22:03, fgorski wrote:
> IsUserRequestedPage

Done.

[romax, 2016-08-24 17:26:27]

The CQ bit was checked by romax@chromium.org

[romax, 2016-08-24 17:26:27]

The patchset sent to the CQ was uploaded after l-g-t-m from
msramek@chromium.org, dimich@chromium.org, fgorski@chromium.org
Link to the patchset: https://codereview.chromium.org/2275833002/#ps20001
(title: "Comments.")

[commit-bot: I haz the power, 2016-08-24 17:27:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 20:46:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 20:46:43]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[romax, 2016-08-24 21:14:57]

The CQ bit was checked by romax@chromium.org

[commit-bot: I haz the power, 2016-08-24 21:15:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 22:42:24]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-24 22:44:47]

Description was changed from

==========
[Offline Pages] Don't remove user-requested pages when deleting cache.

When deleting cache in settings, the user-requested pages shouldn't be
deleted. Adding a check for namespace in the method called by browsing
data remover, filtering out the user-requested pages.

BUG=640416
==========

to

==========
[Offline Pages] Don't remove user-requested pages when deleting cache.

When deleting cache in settings, the user-requested pages shouldn't be
deleted. Adding a check for namespace in the method called by browsing
data remover, filtering out the user-requested pages.

BUG=640416

Committed: https://crrev.com/66a4eb704d562fb4791ac7b84c1d45ce2756e62f
Cr-Commit-Position: refs/heads/master@{#414180}
==========

[commit-bot: I haz the power, 2016-08-24 22:44:48]

Patchset 2 (id:??) landed as
https://crrev.com/66a4eb704d562fb4791ac7b84c1d45ce2756e62f
Cr-Commit-Position: refs/heads/master@{#414180}