components/offline_pages/offline_page_model.h - Issue 2275833002: [Offline Pages] Don't remove user-requested pages when deleting cache.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages/offline_page_model.h

Issue 2275833002: [Offline Pages] Don't remove user-requested pages when deleting cache. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comments. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/offline_pages/offline_page_model.h

diff --git a/components/offline_pages/offline_page_model.h b/components/offline_pages/offline_page_model.h

index 72f9d41778e11e2739c09ee320dc480b49a6a854..59034dac60fbd09b760a2d319aee0f7ce6ac8981 100644

--- a/components/offline_pages/offline_page_model.h

+++ b/components/offline_pages/offline_page_model.h

@@ -103,8 +103,8 @@ class OfflinePageModel : public base::SupportsUserData {

virtual void DeletePagesByOfflineId(const std::vector<int64_t>& offline_ids,

const DeletePageCallback& callback) = 0;

- // Deletes offline pages matching the URL predicate.

- virtual void DeletePagesByURLPredicate(

+ // Deletes cached offline pages matching the URL predicate.

+ virtual void DeleteCachedPagesByURLPredicate(

const UrlPredicate& predicate,

const DeletePageCallback& callback) = 0;

« no previous file with comments | « chrome/browser/browsing_data/browsing_data_remover.cc ('k') | components/offline_pages/offline_page_model_impl.h » ('j') | no next file with comments »