components/offline_pages/stub_offline_page_model.h - Issue 2275833002: [Offline Pages] Don't remove user-requested pages when deleting cache.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages/stub_offline_page_model.h

Issue 2275833002: [Offline Pages] Don't remove user-requested pages when deleting cache. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comments. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/offline_pages/offline_page_model_impl_unittest.cc ('k') | components/offline_pages/stub_offline_page_model.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/offline_pages/stub_offline_page_model.h

diff --git a/components/offline_pages/stub_offline_page_model.h b/components/offline_pages/stub_offline_page_model.h

index d5e0fb80b31c1be0a2999ab587c0ac705f48924d..c08d46a539a8c013665ffe2cec331ad5c1511387 100644

--- a/components/offline_pages/stub_offline_page_model.h

+++ b/components/offline_pages/stub_offline_page_model.h

@@ -32,8 +32,9 @@ class StubOfflinePageModel : public OfflinePageModel {

void ClearAll(const base::Closure& callback) override;

void DeletePagesByOfflineId(const std::vector<int64_t>& offline_ids,

const DeletePageCallback& callback) override;

- void DeletePagesByURLPredicate(const UrlPredicate& predicate,

- const DeletePageCallback& callback) override;

+ void DeleteCachedPagesByURLPredicate(

+ const UrlPredicate& predicate,

+ const DeletePageCallback& callback) override;

void HasPages(const std::string& name_space,

const HasPagesCallback& callback) override;

void CheckPagesExistOffline(