Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 227573002: Return MaybeHandle from SetElement and DeleteElement. (Closed)

Created:
6 years, 8 months ago by Yang
Modified:
6 years, 8 months ago
Reviewers:
Igor Sheludko
CC:
v8-dev
Visibility:
Public.

Description

Return MaybeHandle from SetElement and DeleteElement. R=ishell@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20560

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+305 lines, -300 lines) Patch
M src/api.cc View 5 chunks +18 lines, -14 lines 0 comments Download
M src/ast.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/handles.h View 1 1 chunk +0 lines, -6 lines 0 comments Download
M src/handles.cc View 1 1 chunk +0 lines, -26 lines 0 comments Download
M src/ic.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M src/json-parser.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/liveedit.h View 1 1 chunk +1 line, -4 lines 0 comments Download
M src/liveedit.cc View 1 1 chunk +1 line, -4 lines 0 comments Download
M src/objects.h View 1 10 chunks +61 lines, -47 lines 0 comments Download
M src/objects.cc View 1 36 chunks +153 lines, -124 lines 0 comments Download
M src/runtime.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/runtime.cc View 1 14 chunks +49 lines, -57 lines 0 comments Download
M src/scopes.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-api.cc View 1 chunk +6 lines, -3 lines 0 comments Download
M test/cctest/test-heap.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M test/cctest/test-parsing.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Yang
6 years, 8 months ago (2014-04-07 09:53:49 UTC) #1
Igor Sheludko
lgtm with a nit: https://codereview.chromium.org/227573002/diff/1/src/api.cc File src/api.cc (right): https://codereview.chromium.org/227573002/diff/1/src/api.cc#newcode3398 src/api.cc:3398: EXCEPTION_PREAMBLE(isolate); MaybeHandle<> concept really helps! ...
6 years, 8 months ago (2014-04-07 15:32:31 UTC) #2
Yang
https://codereview.chromium.org/227573002/diff/1/src/api.cc File src/api.cc (right): https://codereview.chromium.org/227573002/diff/1/src/api.cc#newcode3398 src/api.cc:3398: EXCEPTION_PREAMBLE(isolate); On 2014/04/07 15:32:31, Igor Sheludko wrote: > MaybeHandle<> ...
6 years, 8 months ago (2014-04-08 06:51:42 UTC) #3
Yang
6 years, 8 months ago (2014-04-08 07:04:26 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 manually as r20560 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698