src/ast.cc - Issue 227573002: Return MaybeHandle from SetElement and DeleteElement.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ast.cc

Issue 227573002: Return MaybeHandle from SetElement and DeleteElement. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ast.cc

diff --git a/src/ast.cc b/src/ast.cc

index 4781143d7d9b82f50064da3a310ce089131d88fe..b522c98b9a186ebf6ffdccb230336335ddfb98bb 100644

--- a/src/ast.cc

+++ b/src/ast.cc

@@ -378,9 +378,9 @@ void ArrayLiteral::BuildConstantElements(Isolate* isolate) {

} else if (boilerplate_value->IsUninitialized()) {

is_simple = false;

JSObject::SetOwnElement(

- array, i, handle(Smi::FromInt(0), isolate), SLOPPY);

+ array, i, handle(Smi::FromInt(0), isolate), SLOPPY).Assert();

} else {

- JSObject::SetOwnElement(array, i, boilerplate_value, SLOPPY);

+ JSObject::SetOwnElement(array, i, boilerplate_value, SLOPPY).Assert();

}

« no previous file with comments | « src/api.cc ('k') | src/handles.h » ('j') | no next file with comments »