src/liveedit.h - Issue 227573002: Return MaybeHandle from SetElement and DeleteElement.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/liveedit.h

Issue 227573002: Return MaybeHandle from SetElement and DeleteElement. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/liveedit.h

diff --git a/src/liveedit.h b/src/liveedit.h

index 7f1cb5216f2c9fe4e06b535d6c5b2e15007f4021..df2280d8cfd8885146f18db441033d879433bf6f 100644

--- a/src/liveedit.h

+++ b/src/liveedit.h

@@ -208,10 +208,7 @@ class JSArrayBasedStruct {

protected:

void SetField(int field_position, Handle<Object> value) {

- Handle<Object> no_failure =

- JSObject::SetElement(array_, field_position, value, NONE, SLOPPY);

- ASSERT(!no_failure.is_null());

- USE(no_failure);

+ JSObject::SetElement(array_, field_position, value, NONE, SLOPPY).Assert();

}

void SetSmiValueField(int field_position, int value) {

« no previous file with comments | « src/json-parser.h ('k') | src/liveedit.cc » ('j') | no next file with comments »