Make indirect object holder private.

Make indirect object holder private.

This CL moves the m_IndirectObjs map to be private to the IndirectObjectHolder.
Various bits of code have been updated to use the accessors to the map.

This CL fixes the issue with the last time this landed by removing the objnum
check from GetIndirectObject() which appears to have caused the crashes.

Committed: https://pdfium.googlesource.com/pdfium/+/e07edce5b253bc4f2bef6888c5b1cbf0b320a919

[dsinclair, 2016-08-23 20:00:40]

The CQ bit was checked by dsinclair@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-23 20:00:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dsinclair, 2016-08-23 20:02:22]

dsinclair@chromium.org changed reviewers:
+ thestig@chromium.org, tsepez@chromium.org, weili@chromium.org

[dsinclair, 2016-08-23 20:02:22]

PTAL.

I'm splitting up the CL that got reverted
(https://codereview.chromium.org/2253723002/). This is the second part making
the object holder map private.

[commit-bot: I haz the power, 2016-08-23 20:09:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-23 20:09:41]

Dry run: This issue passed the CQ dry run.

[Tom Sepez, 2016-08-24 01:08:56]

lgtm

[dsinclair, 2016-08-24 03:14:05]

The CQ bit was checked by dsinclair@chromium.org

[commit-bot: I haz the power, 2016-08-24 03:14:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 03:14:31]

Description was changed from

==========
Make indirect object holder private.

This CL moves the m_IndirectObjs map to be private to the IndirectObjectHolder.
Various bits of code have been updated to use the accessors to the map.

This CL fixes the issue with the last time this landed by removing the objnum
check from GetIndirectObject() which appears to have caused the crashes.
==========

to

==========
Make indirect object holder private.

This CL moves the m_IndirectObjs map to be private to the IndirectObjectHolder.
Various bits of code have been updated to use the accessors to the map.

This CL fixes the issue with the last time this landed by removing the objnum
check from GetIndirectObject() which appears to have caused the crashes.

Committed:
https://pdfium.googlesource.com/pdfium/+/e07edce5b253bc4f2bef6888c5b1cbf0b320...
==========

[commit-bot: I haz the power, 2016-08-24 03:14:33]

Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/e07edce5b253bc4f2bef6888c5b1cbf0b320...