core/fpdfapi/fpdf_parser/cpdf_document.cpp - Issue 2275703002: Make indirect object holder private.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/fpdf_parser/cpdf_document.cpp

Issue 2275703002: Make indirect object holder private. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@indirect_naming

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfapi/fpdf_parser/cpdf_document.cpp

diff --git a/core/fpdfapi/fpdf_parser/cpdf_document.cpp b/core/fpdfapi/fpdf_parser/cpdf_document.cpp

index a05a24e07f7de412eafb331539c6542860812865..31d44b01fe72c18c4f058787d60177b1f6596314 100644

--- a/core/fpdfapi/fpdf_parser/cpdf_document.cpp

+++ b/core/fpdfapi/fpdf_parser/cpdf_document.cpp

@@ -729,9 +729,9 @@ uint32_t CPDF_Document::GetUserPermissions() const {

}

FX_BOOL CPDF_Document::IsFormStream(uint32_t objnum, FX_BOOL& bForm) const {

- auto it = m_IndirectObjs.find(objnum);

- if (it != m_IndirectObjs.end()) {

- CPDF_Stream* pStream = it->second->AsStream();

+ CPDF_Object* pObj = GetIndirectObject(objnum);

+ if (pObj) {

+ CPDF_Stream* pStream = pObj->AsStream();

bForm = pStream && pStream->GetDict()->GetStringBy("Subtype") == "Form";

return TRUE;

}