Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 2275593002: IndirectObjectHolder API updates (Closed)

Created:
4 years, 4 months ago by dsinclair
Modified:
4 years, 3 months ago
Reviewers:
Tom Sepez, Lei Zhang, Wei Li
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

IndirectObjectHolder API updates This Cl updates the names of the methods in the indirect object holder to better reflect their usage. The m_LastObjNum is made private and a setter added. Committed: https://pdfium.googlesource.com/pdfium/+/03bd7c78ff0411f0db033b5e6b5bf00c7fe2fb87

Patch Set 1 #

Patch Set 2 : Missed one #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -35 lines) Patch
M core/fpdfapi/fpdf_edit/fpdf_edit_create.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M core/fpdfapi/fpdf_parser/cfdf_document.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_array_unittest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_data_avail.cpp View 1 2 chunks +4 lines, -2 lines 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_document.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_indirect_object_holder.cpp View 1 3 chunks +15 lines, -13 lines 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_object_unittest.cpp View 1 1 chunk +3 lines, -2 lines 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_parser.cpp View 1 3 chunks +6 lines, -3 lines 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_reference.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M core/fpdfapi/fpdf_parser/include/cpdf_indirect_object_holder.h View 1 2 chunks +10 lines, -5 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 17 (12 generated)
dsinclair
PTAL. I'm splitting up the CL that got reverted (https://codereview.chromium.org/2253723002/). This is the first part ...
4 years, 4 months ago (2016-08-23 14:20:34 UTC) #4
dsinclair
4 years, 3 months ago (2016-08-23 20:02:39 UTC) #12
Tom Sepez
lgtm
4 years, 3 months ago (2016-08-24 01:07:35 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2275593002/20001
4 years, 3 months ago (2016-08-24 03:13:27 UTC) #15
commit-bot: I haz the power
4 years, 3 months ago (2016-08-24 03:13:46 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/03bd7c78ff0411f0db033b5e6b5bf00c7fe2...

Powered by Google App Engine
This is Rietveld 408576698