Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1449)

Unified Diff: tools/perf/benchmarks/spaceport.py

Issue 22754003: Refactor BenchmarkResult.Add to take enum for data_type (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/benchmarks/octane.py ('k') | tools/perf/benchmarks/sunspider.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/spaceport.py
===================================================================
--- tools/perf/benchmarks/spaceport.py (revision 222891)
+++ tools/perf/benchmarks/spaceport.py (working copy)
@@ -10,6 +10,7 @@
from telemetry import test
from telemetry.core import util
from telemetry.page import page_measurement
+from telemetry.page import result_data_type
from telemetry.page import page_set
@@ -49,7 +50,7 @@
for key in result_dict:
chart, trace = key.split('.', 1)
results.Add(trace, 'objects (bigger is better)', float(result_dict[key]),
- chart_name=chart, data_type='unimportant')
+ chart_name=chart, data_type=result_data_type.UNIMPORTANT)
results.Add('Score', 'objects (bigger is better)',
[float(x) for x in result_dict.values()])
« no previous file with comments | « tools/perf/benchmarks/octane.py ('k') | tools/perf/benchmarks/sunspider.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698