Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Unified Diff: tools/perf/benchmarks/sunspider.py

Issue 22754003: Refactor BenchmarkResult.Add to take enum for data_type (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/benchmarks/spaceport.py ('k') | tools/perf/measurements/dromaeo.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/sunspider.py
===================================================================
--- tools/perf/benchmarks/sunspider.py (revision 222891)
+++ tools/perf/benchmarks/sunspider.py (working copy)
@@ -10,7 +10,11 @@
from telemetry.page import page_measurement
from telemetry.page import page_set
+# Get build scripts into our path.
+util.AddDirToPythonPath(util.GetChromiumSrcDir(), 'build', 'util', 'lib')
+from common import perf_result_data_type # pylint: disable=F0401
+
class SunspiderMeasurement(page_measurement.PageMeasurement):
def MeasurePage(self, _, tab, results):
js_is_done = ('window.location.pathname.indexOf("results.html") >= 0'
@@ -33,7 +37,8 @@
total += value
totals.append(total)
for key, values in r.iteritems():
- results.Add(key, 'ms', values, data_type='unimportant')
+ results.Add(key, 'ms', values,
+ data_type=perf_result_data_type.UNIMPORTANT)
results.Add('Total', 'ms', totals)
« no previous file with comments | « tools/perf/benchmarks/spaceport.py ('k') | tools/perf/measurements/dromaeo.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698