Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(694)

Unified Diff: tools/perf/benchmarks/octane.py

Issue 22754003: Refactor BenchmarkResult.Add to take enum for data_type (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/benchmarks/kraken.py ('k') | tools/perf/benchmarks/spaceport.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/octane.py
===================================================================
--- tools/perf/benchmarks/octane.py (revision 222891)
+++ tools/perf/benchmarks/octane.py (working copy)
@@ -9,7 +9,11 @@
from telemetry.page import page_measurement
from telemetry.page import page_set
+# Get build scripts into our path.
+util.AddDirToPythonPath(util.GetChromiumSrcDir(), 'build', 'util', 'lib')
+from common import perf_result_data_type # pylint: disable=F0401
+
class OctaneMeasurement(page_measurement.PageMeasurement):
def MeasurePage(self, _, tab, results):
js_is_done = """
@@ -36,9 +40,9 @@
for key, value in result_dict.iteritems():
if value == '...':
continue
- data_type = 'unimportant'
+ data_type = perf_result_data_type.UNIMPORTANT
if key == 'score':
- data_type = 'default'
+ data_type = perf_result_data_type.DEFAULT
results.Add(key, 'score (bigger is better)', value, data_type=data_type)
« no previous file with comments | « tools/perf/benchmarks/kraken.py ('k') | tools/perf/benchmarks/spaceport.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698