Milo: pRPC endpoint for getting Buildbot master data

Milo: pRPC endpoint for getting Buildbot master data

g/prpc endpoints are done via a grpc.go file in each of the modules (in contrast to the html.go file)

In addition:
* Master fetches are done in getMasterEntry(), which performs the ACL check for both html and grpc endpoints
* Added symlinks for rpcexplorer static assets

BUG=639900
Committed: https://github.com/luci/luci-go/commit/1eff02f4e6c4deaaa26c9096eb87dfd47d4c9cd6

[Ryan Tseng, 2016-08-24 23:27:31]

The CQ bit was checked by hinoka@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-24 23:27:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ryan Tseng, 2016-08-24 23:31:22]

Cleanup

[Ryan Tseng, 2016-08-24 23:31:23]

The CQ bit was checked by hinoka@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-24 23:31:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ryan Tseng, 2016-08-24 23:31:37]

Description was changed from

==========
Milo: pRPC endpoint for getting Buildbot master data

BUG=639900
==========

to

==========
Milo: pRPC endpoint for getting Buildbot master data

g/prpc endpoints are done via a grpc.go file in each of the modules (in contrast
to the html.go file)

In addition:
* Master fetches are done in getMasterEntry(), which performs the ACL check for
both html and grpc endpoints
* Added rpcexplorer static assets

BUG=639900
==========

[Ryan Tseng, 2016-08-24 23:32:06]

Description was changed from

==========
Milo: pRPC endpoint for getting Buildbot master data

g/prpc endpoints are done via a grpc.go file in each of the modules (in contrast
to the html.go file)

In addition:
* Master fetches are done in getMasterEntry(), which performs the ACL check for
both html and grpc endpoints
* Added rpcexplorer static assets

BUG=639900
==========

to

==========
Milo: pRPC endpoint for getting Buildbot master data

g/prpc endpoints are done via a grpc.go file in each of the modules (in contrast
to the html.go file)

In addition:
* Master fetches are done in getMasterEntry(), which performs the ACL check for
both html and grpc endpoints
* Added symlinks for rpcexplorer static assets

BUG=639900
==========

[commit-bot: I haz the power, 2016-08-24 23:35:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 23:35:40]

Dry run: Try jobs failed on following builders:
  Luci-go Linux Precise 32 Tester on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/30d7b6a9f1ae4b10)
  Luci-go Mac Tester on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/30d7b6a87b9ad710)

[Ryan Tseng, 2016-08-24 23:51:11]

The CQ bit was checked by hinoka@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-24 23:51:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ryan Tseng, 2016-08-24 23:56:01]

Update config tests

[Ryan Tseng, 2016-08-24 23:56:02]

The CQ bit was checked by hinoka@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-24 23:56:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 00:03:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-25 00:03:15]

Dry run: This issue passed the CQ dry run.

[Ryan Tseng, 2016-08-25 00:08:29]

hinoka@google.com changed reviewers:
+ dnj@chromium.org

[Ryan Tseng, 2016-08-25 00:08:30]

ptal to see if I'm doing prpc right

[Ryan Tseng, 2016-08-25 00:13:19]

oh, also, demo:
https://1082-63a9cfa-tainted-hinoka-dot-luci-milo.appspot.com/rpcexplorer/ser...

[Ryan Tseng, 2016-08-30 17:48:34]

hinoka@google.com changed reviewers:
+ estaab@chromium.org

[Ryan Tseng, 2016-08-30 17:48:35]

ptal, this will help us move off CBE

[Ryan Tseng, 2016-08-31 19:44:15]

hinoka@google.com changed reviewers:
+ iannucci@chromium.org
- dnj@chromium.org, estaab@chromium.org

[Ryan Tseng, 2016-08-31 19:44:16]

Hey robbie, dnj is out today so can you take a look at this pRPC CL?

[iannucci, 2016-09-01 00:37:25]

iannucci@chromium.org changed reviewers:
+ estaab@chromium.org

[iannucci, 2016-09-01 00:37:26]

erik may want to take a look, but otherwise lgtm

https://codereview.chromium.org/2275123002/diff/60001/milo/api/proto/buildbot...
File milo/api/proto/buildbot.proto (right):

https://codereview.chromium.org/2275123002/diff/60001/milo/api/proto/buildbot...
milo/api/proto/buildbot.proto:13: rpc GetMaster (MasterRequest) returns
(MasterReply) {}
nit: no space between GetMaster and its argument (IMO, YMMV)

Can we call this GetCompressedMasterJSON? I think there's probably room in the
future to return something other than a gzip blob.

https://codereview.chromium.org/2275123002/diff/60001/milo/api/proto/buildbot...
milo/api/proto/buildbot.proto:29: // Gzipped json data of the master.
barf :(

https://codereview.chromium.org/2275123002/diff/60001/milo/appengine/buildbot...
File milo/appengine/buildbot/master.go (right):

https://codereview.chromium.org/2275123002/diff/60001/milo/appengine/buildbot...
milo/appengine/buildbot/master.go:49: err := ds.Get(&entry)
pretty unfortunate that any user can make us load 1MB without an ACL check :/

[Ryan Tseng, 2016-09-03 00:31:34]

Rebase

[Ryan Tseng, 2016-09-03 00:31:34]

The CQ bit was checked by hinoka@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-03 00:31:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-03 00:34:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-03 00:34:54]

Dry run: Try jobs failed on following builders:
  Luci-go Linux Trusty 64 Tester on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/310646f09140fe10)

[Ryan Tseng, 2016-09-03 00:36:17]

Rebase fix

[Ryan Tseng, 2016-09-03 00:36:17]

The CQ bit was checked by hinoka@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-03 00:36:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-03 00:46:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-03 00:46:15]

Dry run: This issue passed the CQ dry run.

[Ryan Tseng, 2016-09-03 00:47:07]

Renamed stuff

[Ryan Tseng, 2016-09-03 00:47:08]

The CQ bit was checked by hinoka@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-03 00:47:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hinoka, 2016-09-03 00:52:26]

hinoka@chromium.org changed reviewers:
+ hinoka@chromium.org

[hinoka, 2016-09-03 00:52:27]

https://codereview.chromium.org/2275123002/diff/60001/milo/api/proto/buildbot...
File milo/api/proto/buildbot.proto (right):

https://codereview.chromium.org/2275123002/diff/60001/milo/api/proto/buildbot...
milo/api/proto/buildbot.proto:13: rpc GetMaster (MasterRequest) returns
(MasterReply) {}
On 2016/09/01 00:37:26, iannucci wrote:
> nit: no space between GetMaster and its argument (IMO, YMMV)
> 
> Can we call this GetCompressedMasterJSON? I think there's probably room in the
> future to return something other than a gzip blob.

Done.

https://codereview.chromium.org/2275123002/diff/60001/milo/appengine/buildbot...
File milo/appengine/buildbot/master.go (right):

https://codereview.chromium.org/2275123002/diff/60001/milo/appengine/buildbot...
milo/appengine/buildbot/master.go:49: err := ds.Get(&entry)
On 2016/09/01 00:37:26, iannucci wrote:
> pretty unfortunate that any user can make us load 1MB without an ACL check :/

They could before too, but at least now appengine is taking the load :)

[hinoka, 2016-09-03 00:52:34]

The CQ bit was unchecked by hinoka@chromium.org

[hinoka, 2016-09-03 00:52:38]

The CQ bit was checked by hinoka@chromium.org

[hinoka, 2016-09-03 00:52:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
iannucci@chromium.org
Link to the patchset: https://codereview.chromium.org/2275123002/#ps120001
(title: "Renamed stuff")

[commit-bot: I haz the power, 2016-09-03 00:52:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-03 00:58:16]

Description was changed from

==========
Milo: pRPC endpoint for getting Buildbot master data

g/prpc endpoints are done via a grpc.go file in each of the modules (in contrast
to the html.go file)

In addition:
* Master fetches are done in getMasterEntry(), which performs the ACL check for
both html and grpc endpoints
* Added symlinks for rpcexplorer static assets

BUG=639900
==========

to

==========
Milo: pRPC endpoint for getting Buildbot master data

g/prpc endpoints are done via a grpc.go file in each of the modules (in contrast
to the html.go file)

In addition:
* Master fetches are done in getMasterEntry(), which performs the ACL check for
both html and grpc endpoints
* Added symlinks for rpcexplorer static assets

BUG=639900

Committed:
https://github.com/luci/luci-go/commit/1eff02f4e6c4deaaa26c9096eb87dfd47d4c9cd6
==========

[commit-bot: I haz the power, 2016-09-03 00:58:17]

Committed patchset #7 (id:120001) as
https://github.com/luci/luci-go/commit/1eff02f4e6c4deaaa26c9096eb87dfd47d4c9cd6