Milo: pRPC endpoint for getting Buildbot master data

milo/appengine/buildbot/builder.go

 // Copyright 2016 The LUCI Authors. All rights reserved.
 // Use of this source code is governed under the Apache License, Version 2.0
 // that can be found in the LICENSE file.
 
 package buildbot
 
 import (
         "encoding/json"
         "fmt"
-        "net/http"
         "os"
         "sort"
         "strings"
         "time"
 
         "github.com/luci/gae/service/datastore"
 
         "github.com/luci/luci-go/common/clock"
         "github.com/luci/luci-go/common/logging"
         "github.com/luci/luci-go/milo/api/resp"
-        "github.com/luci/luci-go/milo/appengine/settings"
-        "github.com/luci/luci-go/milo/common/miloerror"
         "golang.org/x/net/context"
 )
 
 // builderRef is used for keying specific builds in a master json.
 type builderRef struct {
         builder  string
         buildNum int
 }
 
 // buildMap contains all of the current build within a master json.  We use this
@@ skipping 74 matching lines @@
         bMap := createRunningBuildMap(master)
         for _, bn := range b.Currentbuilds {
                 cb := getCurrentBuild(c, bMap, builderName, bn)
                 if cb != nil {
                         results = append(results, cb)
                 }
         }
         return results
 }
 
-var errMasterNotFound = miloerror.Error{
-        Message: "Master not found",
-        Code:    http.StatusNotFound,
-}
-
 // builderImpl is the implementation for getting a milo builder page from buildbot.
 // This gets:
 // * Current Builds from querying the master json from the datastore.
 // * Recent Builds from a cron job that backfills the recent builds.
 func builderImpl(c context.Context, masterName, builderName string) (*resp.Builder, error) {
         result := &resp.Builder{}
-        master, internal, t, err := getMasterJSON(c, masterName)
-        if internal {
-                allowed, err := settings.IsAllowedInternal(c)
-                if err != nil {
-                        return nil, err
-                }
-                if !allowed {
-                        return nil, errMasterNotFound
-                }
-        }
+        master, t, err := getMasterJSON(c, masterName)
         switch {
         case err == datastore.ErrNoSuchEntity:
                 return nil, errMasterNotFound
         case err != nil:
                 return nil, err
         }
         if clock.Now(c).Sub(t) > 2*time.Minute {
                 warning := fmt.Sprintf(
                         "WARNING: Master data is stale (last updated %s)", t)
                 logging.Warningf(c, warning)
@@ skipping 27 matching lines @@
         result.CurrentBuilds = currentBuilds
         for _, fb := range recentBuilds {
                 // Yes recent builds is synonymous with finished builds.
                 // TODO(hinoka): Implement limits.
                 if fb != nil {
                         result.FinishedBuilds = append(result.FinishedBuilds, fb)
                 }
         }
         return result, nil
 }