Milo: pRPC endpoint for getting Buildbot master data

milo/appengine/buildbot/pubsub_test.go

 // Copyright 2016 The LUCI Authors. All rights reserved.
 // Use of this source code is governed under the Apache License, Version 2.0
 // that can be found in the LICENSE file.
 
 package buildbot
 
 import (
         "bytes"
         "compress/zlib"
         "encoding/base64"
         "encoding/json"
         "io"
         "io/ioutil"
         "net/http"
         "net/http/httptest"
         "testing"
         "time"
 
         "github.com/julienschmidt/httprouter"
         "github.com/luci/gae/impl/memory"
         "github.com/luci/gae/service/datastore"
         "github.com/luci/luci-go/common/clock/testclock"
-        "github.com/luci/luci-go/server/router"
-        //log "github.com/luci/luci-go/common/logging"
+        lucicfg "github.com/luci/luci-go/common/config"
+        memcfg "github.com/luci/luci-go/common/config/impl/memory"
         "github.com/luci/luci-go/common/logging/gologger"
         . "github.com/luci/luci-go/common/testing/assertions"
+        "github.com/luci/luci-go/milo/appengine/settings"
+        "github.com/luci/luci-go/server/auth"
+        "github.com/luci/luci-go/server/auth/authtest"
+        "github.com/luci/luci-go/server/router"
         . "github.com/smartystreets/goconvey/convey"
         "golang.org/x/net/context"
 )
 
 var (
         fakeTime = time.Date(2001, time.February, 3, 4, 5, 6, 7, time.UTC)
 )
 
 func buildbotTimesFinished(start, end float64) []*float64 {
         return []*float64{&start, &end}
@@ skipping 22 matching lines @@
                 Message: pubSubMessage{
                         Data: base64.StdEncoding.EncodeToString(b.Bytes()),
                 },
         }
         jmsg, _ := json.Marshal(msg)
         return ioutil.NopCloser(bytes.NewReader(jmsg))
 }
 
 func TestPubSub(t *testing.T) {
         Convey(`A test Environment`, t, func() {
-                c := memory.Use(context.Background())
+                c := memory.UseWithAppID(context.Background(), "dev~luci-milo")
                 c = gologger.StdConfig.Use(c)
                 c, _ = testclock.UseTime(c, fakeTime)
                 ds := datastore.Get(c)
 
                 Convey("Save build entry", func() {
                         build := &buildbotBuild{
                                 Master:      "Fake Master",
                                 Buildername: "Fake buildername",
                                 Number:      1234,
                                 Currentstep: "this is a string",
@@ skipping 117 matching lines @@
                         Convey("And stores correctly", func() {
                                 loadB := &buildbotBuild{
                                         Master:      "Fake Master",
                                         Buildername: "Fake buildername",
                                         Number:      1234,
                                 }
                                 err := ds.Get(loadB)
                                 So(err, ShouldBeNil)
                                 So(loadB.Master, ShouldEqual, "Fake Master")
                                 So(loadB.Currentstep.(string), ShouldEqual, "this is a string")
-                                m, internal, t, err := getMasterJSON(c, "fakename")
+                                m, t, err := getMasterJSON(c, "fakename")
                                 So(err, ShouldBeNil)
-                                So(internal, ShouldEqual, false)
                                 So(t.Unix(), ShouldEqual, 981173106)
                                 So(m.Name, ShouldEqual, "fakename")
                                 So(m.Project.Title, ShouldEqual, "some title")
                                 So(m.Slaves["testslave"].Name, ShouldEqual, "testslave")
                                 So(len(m.Slaves["testslave"].Runningbuilds), ShouldEqual, 0)
                                 So(len(m.Slaves["testslave"].RunningbuildsMap), ShouldEqual, 1)
                                 So(m.Slaves["testslave"].RunningbuildsMap["Fake buildername"][0],
                                         ShouldEqual, 2222)
                         })
 
                         Convey("And a new master overwrites", func() {
                                 c, _ = testclock.UseTime(c, fakeTime.Add(time.Duration(1*time.Second)))
                                 ms.Project.Title = "some other title"
                                 h = httptest.NewRecorder()
                                 r := &http.Request{
                                         Body: newCombinedPsBody([]buildbotBuild{b}, &ms, false)}
                                 p = httprouter.Params{}
                                 PubSubHandler(&router.Context{
                                         Context: c,
                                         Writer:  h,
                                         Request: r,
                                         Params:  p,
                                 })
                                 So(h.Code, ShouldEqual, 200)
-                                m, internal, t, err := getMasterJSON(c, "fakename")
+                                m, t, err := getMasterJSON(c, "fakename")
                                 So(err, ShouldBeNil)
-                                So(internal, ShouldEqual, false)
                                 So(m.Project.Title, ShouldEqual, "some other title")
                                 So(t.Unix(), ShouldEqual, 981173107)
                                 So(m.Name, ShouldEqual, "fakename")
                         })
                         Convey("And a new build overwrites", func() {
                                 b.Times = buildbotTimesFinished(123.0, 124.0)
                                 h = httptest.NewRecorder()
                                 r = &http.Request{
                                         Body: newCombinedPsBody([]buildbotBuild{b}, &ms, false),
                                 }
@@ skipping 80 matching lines @@
                         }
                         p := httprouter.Params{}
                         PubSubHandler(&router.Context{
                                 Context: c,
                                 Writer:  h,
                                 Request: r,
                                 Params:  p,
                         })
                         So(h.Code, ShouldEqual, 200)
                         Convey("And stores correctly", func() {
+                                c = lucicfg.SetImplementation(c, memcfg.New(aclConfgs))
+                                err := settings.Update(c)
+                                So(err, ShouldBeNil)
+                                c = auth.WithState(c, &authtest.FakeState{
+                                        Identity:       "user:alicebob@google.com",
+                                        IdentityGroups: []string{"google.com", "all"},
+                                })
                                 loadB := &buildbotBuild{
                                         Master:      "Fake Master",
                                         Buildername: "Fake buildername",
                                         Number:      1234,
                                 }
-                                err := ds.Get(loadB)
+                                err = ds.Get(loadB)
                                 So(err, ShouldBeNil)
                                 So(loadB.Master, ShouldEqual, "Fake Master")
                                 So(loadB.Internal, ShouldEqual, true)
                                 So(loadB.Currentstep.(string), ShouldEqual, "this is a string")
-                                m, internal, t, err := getMasterJSON(c, "fakename")
+                                m, t, err := getMasterJSON(c, "fakename")
                                 So(err, ShouldBeNil)
-                                So(internal, ShouldEqual, true)
                                 So(t.Unix(), ShouldEqual, 981173106)
                                 So(m.Name, ShouldEqual, "fakename")
                                 So(m.Project.Title, ShouldEqual, "some title")
                                 So(m.Slaves["testslave"].Name, ShouldEqual, "testslave")
                                 So(len(m.Slaves["testslave"].Runningbuilds), ShouldEqual, 0)
                                 So(len(m.Slaves["testslave"].RunningbuildsMap), ShouldEqual, 1)
                                 So(m.Slaves["testslave"].RunningbuildsMap["Fake buildername"][0],
                                         ShouldEqual, 2222)
                         })
                 })
         })
 }
+
+var secretProjectCfg = `
+ID: "buildbot-internal"
+Readers: "google.com"
+`
+
+var aclConfgs = map[string]memcfg.ConfigSet{
+        "projects/buildbot-internal.git": {
+                "luci-milo.cfg": secretProjectCfg,
+        },
+}