net/socket/socks_client_socket.h - Issue 227473008: make SetReceiveBufferSize and SetSendBufferSize return net error codes (instead of bools)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/socket/socks_client_socket.h

Issue 227473008: make SetReceiveBufferSize and SetSendBufferSize return net error codes (instead of bools) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Original CL, as was submitted, and previously reverted Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/socket/socks_client_socket.h

diff --git a/net/socket/socks_client_socket.h b/net/socket/socks_client_socket.h

index be05ce0fad0804a5a2930c4ecb1c3a879f6edf61..26da332b3ea2da7ebdc0fe5bdb98088b7048575b 100644

--- a/net/socket/socks_client_socket.h

+++ b/net/socket/socks_client_socket.h

@@ -61,8 +61,8 @@ class NET_EXPORT_PRIVATE SOCKSClientSocket : public StreamSocket {

int buf_len,

const CompletionCallback& callback) OVERRIDE;

- virtual bool SetReceiveBufferSize(int32 size) OVERRIDE;

- virtual bool SetSendBufferSize(int32 size) OVERRIDE;

+ virtual int SetReceiveBufferSize(int32 size) OVERRIDE;

+ virtual int SetSendBufferSize(int32 size) OVERRIDE;

virtual int GetPeerAddress(IPEndPoint* address) const OVERRIDE;

virtual int GetLocalAddress(IPEndPoint* address) const OVERRIDE;

« jingle/glue/pseudotcp_adapter.cc ('K') | « net/socket/socks5_client_socket.cc ('k') | net/socket/socks_client_socket.cc » ('j') | remoting/protocol/channel_multiplexer.cc » ('J')