make SetReceiveBufferSize and SetSendBufferSize return net error codes (instead of bools)

jingle/glue/pseudotcp_adapter.cc

Index: jingle/glue/pseudotcp_adapter.cc
diff --git a/jingle/glue/pseudotcp_adapter.cc b/jingle/glue/pseudotcp_adapter.cc
index afd6c36909a027e165898ea41f704100f2e39014..cdb44a050e671c2c829d46b95fdabdd0768dd8ec 100644
--- a/jingle/glue/pseudotcp_adapter.cc
+++ b/jingle/glue/pseudotcp_adapter.cc
@@ -484,18 +484,18 @@ int PseudoTcpAdapter::Write(net::IOBuffer* buffer, int buffer_size,
   return core_->Write(buffer, buffer_size, callback);
 }
 
-bool PseudoTcpAdapter::SetReceiveBufferSize(int32 size) {
+int PseudoTcpAdapter::SetReceiveBufferSize(int32 size) {
   DCHECK(CalledOnValidThread());
 
   core_->SetReceiveBufferSize(size);
-  return false;
+  return net::OK;

[jar (doing other things), 2014/04/08 16:11:22]

This is one apparent change.

[wtc, 2014/04/08 18:44:38]

You didn't undo this change in patch set 3.

[jar (doing other things), 2014/04/08 23:14:11]

I *tried* to study teh code, and convinced myself that the old (bogus) return
values was not tested.  I will add this to my remedy attempts if the upcoming
landing doesn't take.

 }
 
-bool PseudoTcpAdapter::SetSendBufferSize(int32 size) {
+int PseudoTcpAdapter::SetSendBufferSize(int32 size) {
   DCHECK(CalledOnValidThread());
 
   core_->SetSendBufferSize(size);
-  return false;
+  return net::OK;
 }
 
 int PseudoTcpAdapter::Connect(const net::CompletionCallback& callback) {