Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(608)

Side by Side Diff: net/socket/socks_client_socket.h

Issue 227473008: make SetReceiveBufferSize and SetSendBufferSize return net error codes (instead of bools) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Original CL, as was submitted, and previously reverted Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef NET_SOCKET_SOCKS_CLIENT_SOCKET_H_ 5 #ifndef NET_SOCKET_SOCKS_CLIENT_SOCKET_H_
6 #define NET_SOCKET_SOCKS_CLIENT_SOCKET_H_ 6 #define NET_SOCKET_SOCKS_CLIENT_SOCKET_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
54 virtual bool GetSSLInfo(SSLInfo* ssl_info) OVERRIDE; 54 virtual bool GetSSLInfo(SSLInfo* ssl_info) OVERRIDE;
55 55
56 // Socket implementation. 56 // Socket implementation.
57 virtual int Read(IOBuffer* buf, 57 virtual int Read(IOBuffer* buf,
58 int buf_len, 58 int buf_len,
59 const CompletionCallback& callback) OVERRIDE; 59 const CompletionCallback& callback) OVERRIDE;
60 virtual int Write(IOBuffer* buf, 60 virtual int Write(IOBuffer* buf,
61 int buf_len, 61 int buf_len,
62 const CompletionCallback& callback) OVERRIDE; 62 const CompletionCallback& callback) OVERRIDE;
63 63
64 virtual bool SetReceiveBufferSize(int32 size) OVERRIDE; 64 virtual int SetReceiveBufferSize(int32 size) OVERRIDE;
65 virtual bool SetSendBufferSize(int32 size) OVERRIDE; 65 virtual int SetSendBufferSize(int32 size) OVERRIDE;
66 66
67 virtual int GetPeerAddress(IPEndPoint* address) const OVERRIDE; 67 virtual int GetPeerAddress(IPEndPoint* address) const OVERRIDE;
68 virtual int GetLocalAddress(IPEndPoint* address) const OVERRIDE; 68 virtual int GetLocalAddress(IPEndPoint* address) const OVERRIDE;
69 69
70 private: 70 private:
71 FRIEND_TEST_ALL_PREFIXES(SOCKSClientSocketTest, CompleteHandshake); 71 FRIEND_TEST_ALL_PREFIXES(SOCKSClientSocketTest, CompleteHandshake);
72 FRIEND_TEST_ALL_PREFIXES(SOCKSClientSocketTest, SOCKS4AFailedDNS); 72 FRIEND_TEST_ALL_PREFIXES(SOCKSClientSocketTest, SOCKS4AFailedDNS);
73 FRIEND_TEST_ALL_PREFIXES(SOCKSClientSocketTest, SOCKS4AIfDomainInIPv6); 73 FRIEND_TEST_ALL_PREFIXES(SOCKSClientSocketTest, SOCKS4AIfDomainInIPv6);
74 74
75 enum State { 75 enum State {
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
131 RequestPriority priority_; 131 RequestPriority priority_;
132 132
133 BoundNetLog net_log_; 133 BoundNetLog net_log_;
134 134
135 DISALLOW_COPY_AND_ASSIGN(SOCKSClientSocket); 135 DISALLOW_COPY_AND_ASSIGN(SOCKSClientSocket);
136 }; 136 };
137 137
138 } // namespace net 138 } // namespace net
139 139
140 #endif // NET_SOCKET_SOCKS_CLIENT_SOCKET_H_ 140 #endif // NET_SOCKET_SOCKS_CLIENT_SOCKET_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698