Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1482)

Unified Diff: net/socket/socket.h

Issue 227473008: make SetReceiveBufferSize and SetSendBufferSize return net error codes (instead of bools) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Original CL, as was submitted, and previously reverted Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/socket/socket.h
diff --git a/net/socket/socket.h b/net/socket/socket.h
index fccb25873a452a85d788f93aef323e0148c30bd8..5d9af81f20588d6e421b78c7598aa16755f9b1e8 100644
--- a/net/socket/socket.h
+++ b/net/socket/socket.h
@@ -48,13 +48,13 @@ class NET_EXPORT Socket {
// Set the receive buffer size (in bytes) for the socket.
// Note: changing this value can affect the TCP window size on some platforms.
- // Returns true on success, or false on failure.
- virtual bool SetReceiveBufferSize(int32 size) = 0;
+ // Returns a net error code.
+ virtual int SetReceiveBufferSize(int32 size) = 0;
// Set the send buffer size (in bytes) for the socket.
// Note: changing this value can affect the TCP window size on some platforms.
- // Returns true on success, or false on failure.
- virtual bool SetSendBufferSize(int32 size) = 0;
+ // Returns a net error code.
+ virtual int SetSendBufferSize(int32 size) = 0;
};
} // namespace net

Powered by Google App Engine
This is Rietveld 408576698