net/socket/client_socket_pool_base_unittest.cc - Issue 227473008: make SetReceiveBufferSize and SetSendBufferSize return net error codes (instead of bools)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/socket/client_socket_pool_base_unittest.cc

Issue 227473008: make SetReceiveBufferSize and SetSendBufferSize return net error codes (instead of bools) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Original CL, as was submitted, and previously reverted Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/socket/client_socket_pool_base_unittest.cc

diff --git a/net/socket/client_socket_pool_base_unittest.cc b/net/socket/client_socket_pool_base_unittest.cc

index 605af728c5c514b2b9c4cb5fd43fadd9632672c7..5a672b44a4e99a30fd2583b9a545c84287b9d5b4 100644

--- a/net/socket/client_socket_pool_base_unittest.cc

+++ b/net/socket/client_socket_pool_base_unittest.cc

@@ -145,8 +145,8 @@ class MockClientSocket : public StreamSocket {

was_used_to_convey_data_ = true;

return len;

}

- virtual bool SetReceiveBufferSize(int32 size) OVERRIDE { return true; }

- virtual bool SetSendBufferSize(int32 size) OVERRIDE { return true; }

+ virtual int SetReceiveBufferSize(int32 size) OVERRIDE { return OK; }

+ virtual int SetSendBufferSize(int32 size) OVERRIDE { return OK; }

// StreamSocket implementation.

virtual int Connect(const CompletionCallback& callback) OVERRIDE {

« jingle/glue/pseudotcp_adapter.cc ('K') | « net/socket/buffered_write_stream_socket.cc ('k') | net/socket/socket.h » ('j') | remoting/protocol/channel_multiplexer.cc » ('J')