Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(654)

Unified Diff: net/socket/client_socket_pool_base_unittest.cc

Issue 227473008: make SetReceiveBufferSize and SetSendBufferSize return net error codes (instead of bools) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Original CL, as was submitted, and previously reverted Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/socket/client_socket_pool_base_unittest.cc
diff --git a/net/socket/client_socket_pool_base_unittest.cc b/net/socket/client_socket_pool_base_unittest.cc
index 605af728c5c514b2b9c4cb5fd43fadd9632672c7..5a672b44a4e99a30fd2583b9a545c84287b9d5b4 100644
--- a/net/socket/client_socket_pool_base_unittest.cc
+++ b/net/socket/client_socket_pool_base_unittest.cc
@@ -145,8 +145,8 @@ class MockClientSocket : public StreamSocket {
was_used_to_convey_data_ = true;
return len;
}
- virtual bool SetReceiveBufferSize(int32 size) OVERRIDE { return true; }
- virtual bool SetSendBufferSize(int32 size) OVERRIDE { return true; }
+ virtual int SetReceiveBufferSize(int32 size) OVERRIDE { return OK; }
+ virtual int SetSendBufferSize(int32 size) OVERRIDE { return OK; }
// StreamSocket implementation.
virtual int Connect(const CompletionCallback& callback) OVERRIDE {

Powered by Google App Engine
This is Rietveld 408576698