make SetReceiveBufferSize and SetSendBufferSize return net error codes (instead of bools)

make SetReceiveBufferSize and SetSendBufferSize return net error codes (instead of bools)

Previously committed as https://src.chromium.org/viewvc/chrome?view=rev&revision=261966 but then reverted when it broke the Mac 10.6 build.

TBR=sergeyu,yzshen,yurys,zea
R=wtc
BUG=355222
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262652

[jar (doing other things), 2014-04-08 16:11:22]

Hopefully, this CL, without the attempted-fix in channel_multiplexer.cc, will do
better.

https://codereview.chromium.org/227473008/diff/1/jingle/glue/pseudotcp_adapte...
File jingle/glue/pseudotcp_adapter.cc (right):

https://codereview.chromium.org/227473008/diff/1/jingle/glue/pseudotcp_adapte...
jingle/glue/pseudotcp_adapter.cc:491: return net::OK;
This is one apparent change.

https://codereview.chromium.org/227473008/diff/1/remoting/protocol/channel_mu...
File remoting/protocol/channel_multiplexer.cc (right):

https://codereview.chromium.org/227473008/diff/1/remoting/protocol/channel_mu...
remoting/protocol/channel_multiplexer.cc:137: return false;
This is a second change.

.... which I am not including in this final CL.

[wtc, 2014-04-08 18:44:38]

Patch set 3 LGTM.

https://codereview.chromium.org/227473008/diff/1/jingle/glue/pseudotcp_adapte...
File jingle/glue/pseudotcp_adapter.cc (right):

https://codereview.chromium.org/227473008/diff/1/jingle/glue/pseudotcp_adapte...
jingle/glue/pseudotcp_adapter.cc:491: return net::OK;

On 2014/04/08 16:11:22, jar wrote:
> This is one apparent change.

You didn't undo this change in patch set 3.

https://codereview.chromium.org/227473008/diff/1/remoting/protocol/channel_mu...
File remoting/protocol/channel_multiplexer.cc (right):

https://codereview.chromium.org/227473008/diff/1/remoting/protocol/channel_mu...
remoting/protocol/channel_multiplexer.cc:137: return false;

On 2014/04/08 16:11:22, jar wrote:
> This is a second change.
> 
> .... which I am not including in this final CL.

I agree we should not change this. However, this is cross-platform code and the
NOTIMPLEMENTED() macro is an assertion failure in debug builds. So this won't
explain why the tests only failed (or rather, timed out) on Mac OS X 10.6.

[jar (doing other things), 2014-04-08 23:14:10]

https://codereview.chromium.org/227473008/diff/1/jingle/glue/pseudotcp_adapte...
File jingle/glue/pseudotcp_adapter.cc (right):

https://codereview.chromium.org/227473008/diff/1/jingle/glue/pseudotcp_adapte...
jingle/glue/pseudotcp_adapter.cc:491: return net::OK;
On 2014/04/08 18:44:38, wtc wrote:
> 
> On 2014/04/08 16:11:22, jar wrote:
> > This is one apparent change.
> 
> You didn't undo this change in patch set 3.
> 

I *tried* to study teh code, and convinced myself that the old (bogus) return
values was not tested.  I will add this to my remedy attempts if the upcoming
landing doesn't take.

https://codereview.chromium.org/227473008/diff/1/remoting/protocol/channel_mu...
File remoting/protocol/channel_multiplexer.cc (right):

https://codereview.chromium.org/227473008/diff/1/remoting/protocol/channel_mu...
remoting/protocol/channel_multiplexer.cc:137: return false;
On 2014/04/08 18:44:38, wtc wrote:
> 
> On 2014/04/08 16:11:22, jar wrote:
> > This is a second change.
> > 
> > .... which I am not including in this final CL.
> 
> I agree we should not change this. However, this is cross-platform code and
the
> NOTIMPLEMENTED() macro is an assertion failure in debug builds. So this won't
> explain why the tests only failed (or rather, timed out) on Mac OS X 10.6.

<sigh>... good point.  This can't(?) be causing the debug woes on Mac 10.6.

I guess it is also possible that "although it is not implmented," perhaps the
connection is "always viewed as connected," or in all uses, is "connected" (but
they didn't wire in any testsing of slots in the instance?).

AS a result, I'll avoid changing this, since it is not critical to the intent of
the CL.

[jar (doing other things), 2014-04-09 01:39:19]

The CQ bit was checked by jar@chromium.org

[commit-bot: I haz the power, 2014-04-09 01:54:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jar@chromium.org/227473008/70001

[commit-bot: I haz the power, 2014-04-09 02:04:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jar@chromium.org/227473008/70001

[commit-bot: I haz the power, 2014-04-09 02:22:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jar@chromium.org/227473008/70001

[commit-bot: I haz the power, 2014-04-09 04:41:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jar@chromium.org/227473008/70001

[commit-bot: I haz the power, 2014-04-09 04:46:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jar@chromium.org/227473008/70001

[commit-bot: I haz the power, 2014-04-09 04:52:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jar@chromium.org/227473008/70001

[commit-bot: I haz the power, 2014-04-09 04:56:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jar@chromium.org/227473008/70001

[commit-bot: I haz the power, 2014-04-09 06:42:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jar@chromium.org/227473008/70001

[commit-bot: I haz the power, 2014-04-09 06:49:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jar@chromium.org/227473008/70001

[commit-bot: I haz the power, 2014-04-09 06:55:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jar@chromium.org/227473008/70001

[commit-bot: I haz the power, 2014-04-09 07:02:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jar@chromium.org/227473008/70001

[commit-bot: I haz the power, 2014-04-09 07:08:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jar@chromium.org/227473008/70001

[commit-bot: I haz the power, 2014-04-09 07:16:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jar@chromium.org/227473008/70001

[commit-bot: I haz the power, 2014-04-09 07:22:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jar@chromium.org/227473008/70001

[commit-bot: I haz the power, 2014-04-09 07:28:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jar@chromium.org/227473008/70001

[commit-bot: I haz the power, 2014-04-09 07:36:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jar@chromium.org/227473008/70001

[commit-bot: I haz the power, 2014-04-09 07:44:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jar@chromium.org/227473008/70001

[commit-bot: I haz the power, 2014-04-09 07:51:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jar@chromium.org/227473008/70001

[commit-bot: I haz the power, 2014-04-09 07:58:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jar@chromium.org/227473008/70001

[commit-bot: I haz the power, 2014-04-09 08:05:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jar@chromium.org/227473008/70001

[commit-bot: I haz the power, 2014-04-09 08:12:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jar@chromium.org/227473008/70001

[commit-bot: I haz the power, 2014-04-09 09:05:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jar@chromium.org/227473008/70001

[commit-bot: I haz the power, 2014-04-09 09:13:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jar@chromium.org/227473008/70001

[commit-bot: I haz the power, 2014-04-09 09:21:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jar@chromium.org/227473008/70001

[commit-bot: I haz the power, 2014-04-09 09:28:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jar@chromium.org/227473008/70001

[commit-bot: I haz the power, 2014-04-09 09:40:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jar@chromium.org/227473008/70001

[commit-bot: I haz the power, 2014-04-09 09:49:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jar@chromium.org/227473008/70001

[commit-bot: I haz the power, 2014-04-09 11:09:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jar@chromium.org/227473008/70001

[commit-bot: I haz the power, 2014-04-09 11:21:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jar@chromium.org/227473008/70001

[commit-bot: I haz the power, 2014-04-09 12:21:17]

Change committed as 262652

[wtc, 2014-04-09 15:34:48]

Patch set 5 LGTM. Thanks!

I can take care of fixing the nits.

https://codereview.chromium.org/227473008/diff/70001/net/base/net_errors.cc
File net/base/net_errors.cc (right):

https://codereview.chromium.org/227473008/diff/70001/net/base/net_errors.cc#n...
net/base/net_errors.cc:66: DLOG(WARNING)  << "OS Error was not set meaningfully
" << os_error;

Hmm... the problem with this error message is that it doesn't have a context.
Here are some ideas to provide a context.

1. Also log default_net_error.

2. Add a "failed_function_name" argument to the function.

3. Dump a call stack.

Nit: "meaningfully" seems superfluous. "Error" doesn't need to be capitalized.

https://codereview.chromium.org/227473008/diff/70001/net/base/net_errors.cc#n...
net/base/net_errors.cc:67: DCHECK_NE(default_net_error, OK);

This DCHECK should be at the beginning of the function, so that it is always
executed.

https://codereview.chromium.org/227473008/diff/70001/net/base/net_errors.h
File net/base/net_errors.h (right):

https://codereview.chromium.org/227473008/diff/70001/net/base/net_errors.h#ne...
net/base/net_errors.h:65: int MapSystemErrorWithDefault(int os_error, int
default_net_error);

Nit: please list this function right below the closely related MapSystemError.