make SetReceiveBufferSize and SetSendBufferSize return net error codes (instead of bools)

remoting/protocol/channel_multiplexer.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/protocol/channel_multiplexer.h"
 
 #include <string.h>
 
 #include "base/bind.h"
 #include "base/callback.h"
@@ skipping 98 matching lines @@
   void OnWriteComplete();
   void OnWriteFailed();
   void OnPacketReceived();
 
   // net::StreamSocket interface.
   virtual int Read(net::IOBuffer* buffer, int buffer_len,
                    const net::CompletionCallback& callback) OVERRIDE;
   virtual int Write(net::IOBuffer* buffer, int buffer_len,
                     const net::CompletionCallback& callback) OVERRIDE;
 
-  virtual bool SetReceiveBufferSize(int32 size) OVERRIDE {
+  virtual int SetReceiveBufferSize(int32 size) OVERRIDE {
     NOTIMPLEMENTED();
-    return false;
+    return net::ERR_NOT_IMPLEMENTED;
   }
-  virtual bool SetSendBufferSize(int32 size) OVERRIDE {
+  virtual int SetSendBufferSize(int32 size) OVERRIDE {
     NOTIMPLEMENTED();
-    return false;
+    return net::ERR_NOT_IMPLEMENTED;
   }
 
   virtual int Connect(const net::CompletionCallback& callback) OVERRIDE {
     NOTIMPLEMENTED();
-    return net::ERR_FAILED;
+    return net::ERR_NOT_IMPLEMENTED;
   }
   virtual void Disconnect() OVERRIDE {
     NOTIMPLEMENTED();
   }
   virtual bool IsConnected() const OVERRIDE {
     NOTIMPLEMENTED();
-    return true;
+    return false;

[jar (doing other things), 2014/04/08 16:11:22]

This is a second change.

.... which I am not including in this final CL.

[wtc, 2014/04/08 18:44:38]

I agree we should not change this. However, this is cross-platform code and the
NOTIMPLEMENTED() macro is an assertion failure in debug builds. So this won't
explain why the tests only failed (or rather, timed out) on Mac OS X 10.6.

[jar (doing other things), 2014/04/08 23:14:11]

<sigh>... good point.  This can't(?) be causing the debug woes on Mac 10.6.

I guess it is also possible that "although it is not implmented," perhaps the
connection is "always viewed as connected," or in all uses, is "connected" (but
they didn't wire in any testsing of slots in the instance?).

AS a result, I'll avoid changing this, since it is not critical to the intent of
the CL.

   }
   virtual bool IsConnectedAndIdle() const OVERRIDE {
     NOTIMPLEMENTED();
     return false;
   }
   virtual int GetPeerAddress(net::IPEndPoint* address) const OVERRIDE {
     NOTIMPLEMENTED();
-    return net::ERR_FAILED;
+    return net::ERR_NOT_IMPLEMENTED;
   }
   virtual int GetLocalAddress(net::IPEndPoint* address) const OVERRIDE {
     NOTIMPLEMENTED();
-    return net::ERR_FAILED;
+    return net::ERR_NOT_IMPLEMENTED;
   }
   virtual const net::BoundNetLog& NetLog() const OVERRIDE {
     NOTIMPLEMENTED();
     return net_log_;
   }
   virtual void SetSubresourceSpeculation() OVERRIDE {
     NOTIMPLEMENTED();
   }
   virtual void SetOmniboxSpeculation() OVERRIDE {
     NOTIMPLEMENTED();
@@ skipping 350 matching lines @@
   channel->OnIncomingPacket(packet.Pass(), done_task);
 }
 
 bool ChannelMultiplexer::DoWrite(scoped_ptr<MultiplexPacket> packet,
                                  const base::Closure& done_task) {
   return writer_.Write(SerializeAndFrameMessage(*packet), done_task);
 }
 
 }  // namespace protocol
 }  // namespace remoting