Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(931)

Unified Diff: content/browser/renderer_host/p2p/socket_host_tcp.cc

Issue 227473008: make SetReceiveBufferSize and SetSendBufferSize return net error codes (instead of bools) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix linux typo Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/p2p/socket_host_tcp.cc
diff --git a/content/browser/renderer_host/p2p/socket_host_tcp.cc b/content/browser/renderer_host/p2p/socket_host_tcp.cc
index e1900efad2ffa91eecb3931003f9ce86542169c7..220b3cce6bbec0e1319582307c5189b3cb27b6a5 100644
--- a/content/browser/renderer_host/p2p/socket_host_tcp.cc
+++ b/content/browser/renderer_host/p2p/socket_host_tcp.cc
@@ -205,12 +205,12 @@ void P2PSocketHostTcpBase::ProcessTlsSslConnectDone(int status) {
void P2PSocketHostTcpBase::OnOpen() {
state_ = STATE_OPEN;
// Setting socket send and receive buffer size.
- if (!socket_->SetReceiveBufferSize(kRecvSocketBufferSize)) {
+ if (net::OK != socket_->SetReceiveBufferSize(kRecvSocketBufferSize)) {
LOG(WARNING) << "Failed to set socket receive buffer size to "
<< kRecvSocketBufferSize;
}
- if (!socket_->SetSendBufferSize(kSendSocketBufferSize)) {
+ if (net::OK != socket_->SetSendBufferSize(kSendSocketBufferSize)) {
LOG(WARNING) << "Failed to set socket send buffer size to "
<< kSendSocketBufferSize;
}
@@ -412,9 +412,9 @@ bool P2PSocketHostTcpBase::SetOption(P2PSocketOption option, int value) {
DCHECK_EQ(STATE_OPEN, state_);
switch (option) {
case P2P_SOCKET_OPT_RCVBUF:
- return socket_->SetReceiveBufferSize(value);
+ return socket_->SetReceiveBufferSize(value) == net::OK;
case P2P_SOCKET_OPT_SNDBUF:
- return socket_->SetSendBufferSize(value);
+ return socket_->SetSendBufferSize(value) == net::OK;
case P2P_SOCKET_OPT_DSCP:
return false; // For TCP sockets DSCP setting is not available.
default:

Powered by Google App Engine
This is Rietveld 408576698