Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2274113002: [parser] Clean up (pre)parser traits, part 4 (Closed)

Created:
4 years, 4 months ago by nickie
Modified:
4 years, 3 months ago
Reviewers:
adamk, marja
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[parser] Clean up (pre)parser traits, part 4 This patch moves the following methods from the traits objects to the (pre)parser implementation objects: - ExpressionFromIdentifier - ExpressionFromLiteral - ExpressionFromString - FunctionSentExpression - GetNextSymbol - GetNumberAsSymbol - GetSymbol - NewExpressionList - NewPropertyList - NewStatementList - NewSuperCallReference - NewSuperPropertyReference - NewTargetExpression - ThisExpression Also, the method GetIterator is specific only to the parser and is removed from the preparser's implementation. R=adamk@chromium.org, marja@chromium.org BUG= LOG=N Committed: https://crrev.com/3c1d076a8547014efbab163b0f8e0760f56ccc43 Cr-Commit-Position: refs/heads/master@{#38890}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+201 lines, -248 lines) Patch
M src/parsing/parser.h View 3 chunks +59 lines, -32 lines 0 comments Download
M src/parsing/parser.cc View 9 chunks +47 lines, -102 lines 0 comments Download
M src/parsing/parser-base.h View 21 chunks +26 lines, -30 lines 0 comments Download
M src/parsing/pattern-rewriter.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/parsing/preparser.h View 2 chunks +61 lines, -67 lines 0 comments Download
M src/parsing/preparser.cc View 2 chunks +7 lines, -16 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (6 generated)
nickie
4 years, 4 months ago (2016-08-24 10:42:55 UTC) #1
marja
lgtm
4 years, 4 months ago (2016-08-24 12:05:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2274113002/1
4 years, 3 months ago (2016-08-25 08:43:23 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-25 08:45:06 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 08:45:33 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3c1d076a8547014efbab163b0f8e0760f56ccc43
Cr-Commit-Position: refs/heads/master@{#38890}

Powered by Google App Engine
This is Rietveld 408576698