Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(647)

Unified Diff: src/parsing/preparser.h

Issue 2274113002: [parser] Clean up (pre)parser traits, part 4 (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/parsing/pattern-rewriter.cc ('k') | src/parsing/preparser.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/parsing/preparser.h
diff --git a/src/parsing/preparser.h b/src/parsing/preparser.h
index ce9e1c5c0de82d2b6a727b40f12fda3d890eb6c4..bb18f986718304430ae5f1e4820c132213ff587a 100644
--- a/src/parsing/preparser.h
+++ b/src/parsing/preparser.h
@@ -627,73 +627,6 @@ class ParserBaseTraits<PreParser> {
// A dummy function, just useful as an argument to CHECK_OK_CUSTOM.
static void Void() {}
- // Producing data during the recursive descent.
- PreParserIdentifier GetSymbol(Scanner* scanner) const;
-
- PreParserIdentifier GetNextSymbol(Scanner* scanner) const {
- return PreParserIdentifier::Default();
- }
-
- PreParserIdentifier GetNumberAsSymbol(Scanner* scanner) const {
- return PreParserIdentifier::Default();
- }
-
- PreParserExpression ThisExpression(int pos = kNoSourcePosition) {
- return PreParserExpression::This();
- }
-
- PreParserExpression NewSuperPropertyReference(PreParserFactory* factory,
- int pos) {
- return PreParserExpression::Default();
- }
-
- PreParserExpression NewSuperCallReference(PreParserFactory* factory,
- int pos) {
- return PreParserExpression::SuperCallReference();
- }
-
- PreParserExpression NewTargetExpression(int pos) {
- return PreParserExpression::Default();
- }
-
- PreParserExpression FunctionSentExpression(PreParserFactory* factory,
- int pos) const {
- return PreParserExpression::Default();
- }
-
- PreParserExpression ExpressionFromLiteral(Token::Value token, int pos,
- Scanner* scanner,
- PreParserFactory* factory) const {
- return PreParserExpression::Default();
- }
-
- PreParserExpression ExpressionFromIdentifier(PreParserIdentifier name,
- int start_position,
- int end_position,
- InferName = InferName::kYes) {
- return PreParserExpression::FromIdentifier(name);
- }
-
- PreParserExpression ExpressionFromString(int pos, Scanner* scanner,
- PreParserFactory* factory) const;
-
- PreParserExpression GetIterator(PreParserExpression iterable,
- PreParserFactory* factory, int pos) {
- return PreParserExpression::Default();
- }
-
- PreParserExpressionList NewExpressionList(int size, Zone* zone) const {
- return PreParserExpressionList();
- }
-
- PreParserExpressionList NewPropertyList(int size, Zone* zone) const {
- return PreParserExpressionList();
- }
-
- PreParserStatementList NewStatementList(int size, Zone* zone) const {
- return PreParserStatementList();
- }
-
void AddParameterInitializationBlock(
const PreParserFormalParameters& parameters, PreParserStatementList body,
bool is_async, bool* ok) {}
@@ -1145,6 +1078,67 @@ class PreParser : public ParserBase<PreParser> {
return PreParserExpression::Default();
}
+ // Producing data during the recursive descent.
+ PreParserIdentifier GetSymbol() const;
+
+ V8_INLINE PreParserIdentifier GetNextSymbol() const {
+ return PreParserIdentifier::Default();
+ }
+
+ V8_INLINE PreParserIdentifier GetNumberAsSymbol() const {
+ return PreParserIdentifier::Default();
+ }
+
+ V8_INLINE PreParserExpression ThisExpression(int pos = kNoSourcePosition) {
+ return PreParserExpression::This();
+ }
+
+ V8_INLINE PreParserExpression NewSuperPropertyReference(int pos) {
+ return PreParserExpression::Default();
+ }
+
+ V8_INLINE PreParserExpression NewSuperCallReference(int pos) {
+ return PreParserExpression::SuperCallReference();
+ }
+
+ V8_INLINE PreParserExpression NewTargetExpression(int pos) {
+ return PreParserExpression::Default();
+ }
+
+ V8_INLINE PreParserExpression FunctionSentExpression(int pos) {
+ return PreParserExpression::Default();
+ }
+
+ V8_INLINE PreParserExpression ExpressionFromLiteral(Token::Value token,
+ int pos) {
+ return PreParserExpression::Default();
+ }
+
+ V8_INLINE PreParserExpression ExpressionFromIdentifier(
+ PreParserIdentifier name, int start_position, int end_position,
+ InferName infer = InferName::kYes) {
+ return PreParserExpression::FromIdentifier(name);
+ }
+
+ V8_INLINE PreParserExpression ExpressionFromString(int pos) {
+ if (scanner()->UnescapedLiteralMatches("use strict", 10)) {
+ return PreParserExpression::UseStrictStringLiteral();
+ }
+ return PreParserExpression::StringLiteral();
+ }
+
+ V8_INLINE PreParserExpressionList NewExpressionList(int size) const {
+ return PreParserExpressionList();
+ }
+
+ V8_INLINE PreParserExpressionList NewPropertyList(int size) const {
+ return PreParserExpressionList();
+ }
+
+ V8_INLINE PreParserStatementList NewStatementList(int size) const {
+ return PreParserStatementList();
+ }
+
// Preparser's private field members.
int* use_counts_;
« no previous file with comments | « src/parsing/pattern-rewriter.cc ('k') | src/parsing/preparser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698